[L] Add Review step for Alt text experiment and update publish
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Jul 17 2024, 8:22 PM

Project Tags

Referenced Files

	F57282665: Screenshot 2024-08-20 at 8.50.20 AM.jpeg
	Aug 20 2024, 1:53 PM

	F57282517: IMG_7662 copy.PNG
	Aug 20 2024, 10:23 AM

	F57282515: image.png
	Aug 20 2024, 10:23 AM

	F57282512: IMG_7662.PNG
	Aug 20 2024, 10:23 AM

	F57281246: IMG_7655.png
	Aug 19 2024, 11:53 AM

	F56488763: image.png
	Jul 17 2024, 8:22 PM

Subscribers

View All 9 Subscribers

Description

Background

After a user writes alt text, they should have the opportunity to review what they have written before publishing.

Requirements

Image, Alt text entered, and image caption (if available) are shown for user to review before publishing
"Back" brings them back to the active input box, and text already typed is retained
CC License information is included at the bottom of the page (ok if user needs to scroll to view)
"Publish" publishes the alt text with an automatic edit summary "Added alt text"
Relevant events are instrumented according to Data instrumentation plan and completed slides have been marked with a green background
Translations are added for target languages from UI Copy for Suggested edits Alt text on iOS (T370725)

Design:

Figma:

Engineering notes:

This should be one of the first priorities after MTV
Wikitext publishing should now happen at this step, not the half sheet as in the MTV

Related Objects
Search...

Status	Assigned	Task
Resolved	HNordeenWMF	T357437 [Epic] Alt-Text Suggested Edit Experiment on iOS
Resolved	None	T357440 [Engineering Epic] Alt-text scaled experiment on iOS main flow and actions
Resolved	None	T370359 [L] Add Review step for Alt text experiment and update publish

Event Timeline

HNordeenWMF created this task.Jul 17 2024, 8:22 PM

HNordeenWMF triaged this task as Low priority.

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF mentioned this in T357440: [Engineering Epic] Alt-text scaled experiment on iOS main flow and actions.Jul 17 2024, 9:12 PM

AlexHollender-WMF unsubscribed.Jul 18 2024, 6:41 PM

Tsevener renamed this task from Add Review step for Alt text experiment and update publish to [L] Add Review step for Alt text experiment and update publish.Jul 23 2024, 6:16 PM

Seddon moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jul 23 2024, 6:28 PM

HNordeenWMF raised the priority of this task from Low to Medium.Jul 23 2024, 10:03 PM

Seddon set the point value for this task to 5.Jul 25 2024, 2:28 PM

HNordeenWMF updated the task description. (Show Details)Jul 30 2024, 8:49 PM

Mazevedo moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 5 2024, 3:12 PM

HNordeenWMF updated the task description. (Show Details)Aug 5 2024, 4:40 PM

Tsevener mentioned this in T370236: [M] Publish Wikitext for Alt Text experiment - Flow B.Aug 5 2024, 10:29 PM

Mazevedo claimed this task.Aug 6 2024, 3:04 PM

Mazevedo moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

Hi @scblr here we also have that accessibility icon that we cannot use in this context per Apple's guidelines. Should we remove it from here as well?

@Mazevedo, yes, please remove it as well!

Alevtina_Mashtaler moved this task from Doing to Tasks from Product Backlog on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 10 2024, 8:03 PM

Alevtina_Mashtaler moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 11 2024, 9:50 AM

Tsevener mentioned this in T370327: [L] Modal sheet: Add image and link button, bottom copy/warning and counter, guidance button.Aug 13 2024, 1:27 PM

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/4923

Mazevedo moved this task from Doing to Design signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 16 2024, 3:58 PM

Can be tested on Wikipedia Experimental 7.5.8 (146)

Thanks @Mazevedo for the work on this 👏 I experienced this when trying it out:

Video

Seems like there’s something off with the image crop/fit.

• scblr moved this task from Design signoff to Current Sprint Work on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 19 2024, 12:37 PM

Seddon raised the priority of this task from Medium to High.Aug 19 2024, 8:33 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4923

Tsevener updated the task description. (Show Details)Aug 19 2024, 8:38 PM

@scblr New design review build will be in Experimental 7.5.8 (149).

Tsevener removed Mazevedo as the assignee of this task.Aug 19 2024, 8:42 PM

Tsevener moved this task from Current Sprint Work to Design signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

The only difference is the contents/length of the licensing information. Not quite sure what’s been decided here @Tsevener / @HNordeenWMF?

Implementation	vs	Design

And likely two double spaces in that footer:

IMG_7662 copy.PNG (1,179×2,556 px, 1 MB)

Other than that, it looks good to me. No blockers from my end, I’ll move it forward.

• scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 20 2024, 10:23 AM

@scblr @HNordeenWMF

The only difference is the contents/length of the licensing information.

Tagging @Mazevedo to confirm but it looks like we reused the footer from our editor edit summary screen:

Screenshot 2024-08-20 at 8.50.20 AM.jpeg (1,125×2,436 px, 541 KB)

Hi @scblr! I'm following the copy from the translation sheet. If I used the one in the designs, it wouldn't match the translations. For the extra space, I can remove it in the next task.

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 20 2024, 2:58 PM

Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

I'm following the copy from the translation sheet. If I used the one in the designs, it wouldn't match the translations. For the extra space, I can remove it in the next task.

Ok, that makes sense – thanks @Mazevedo @Tsevener

Looking good on 7.5.8 (3979)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Aug 30 2024, 5:08 PM

@Mazevedo this one is not appearing compatible with dynamic type. I'll make a task for adding it in the permanent version

HNordeenWMF closed this task as Resolved.Sep 5 2024, 11:29 PM

[L] Add Review step for Alt text experiment and update publishClosed, ResolvedPublic5 Estimated Story PointsActions