Page MenuHomePhabricator

Improve feature parity between Special:Contributions and Special:DeletedContributions
Closed, ResolvedPublic

Description

Background

Special:Contributions and Special:DeletedContributions share much in common but appear to have diverged over the years. Features that were added to Special:Contributions were not added to Special:DeletedContributions, e.g. form filters (T36524) and IP range support (T357231).

Technical background

Recently, an abstract parent class was refactored out from Special:Contributions, to allow different-but-similar contributions pages to share logic in one place (T363358). This allowed us to create a new special page (as part of the temporary accounts project) that has two modes: one that queries the revision table (T363357) and one that queries the archive table (T363362).

It should be possible to similarly refactor SpecialDeletedContributions to extend ContributionsSpecialPage, and DeletedContribsPager to extend ContributionsPager, to bring is closer to feature parity with Special:Contributions, particularly with the search form filters.

(Note that IP range handling would be a bit more complicated, since it would also require continuing to store archived contributions in the ip_changes table.)

Related Objects

Event Timeline

Change #1058650 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Re-work comment to be more generic

https://gerrit.wikimedia.org/r/1058650

Change #1058651 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsSpecialPage: Check permissions from execute method

https://gerrit.wikimedia.org/r/1058651

Change #1058653 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] WIP Bring Special:DeletedContributions to parity with Special:Contributions

https://gerrit.wikimedia.org/r/1058653

Change #1058650 merged by jenkins-bot:

[mediawiki/core@master] ContributionsPager: Re-work comment to be more generic

https://gerrit.wikimedia.org/r/1058650

Change #1058651 merged by jenkins-bot:

[mediawiki/core@master] ContributionsSpecialPage: Check permissions from execute method

https://gerrit.wikimedia.org/r/1058651

Change #1059343 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Improve test coverage of DeletedContribsPager

https://gerrit.wikimedia.org/r/1059343

Change #1059344 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Extend ContributionsPager from DeletedContribsPager

https://gerrit.wikimedia.org/r/1059344

Change #1059343 merged by jenkins-bot:

[mediawiki/core@master] Improve test coverage of DeletedContribsPager

https://gerrit.wikimedia.org/r/1059343

Change #1059912 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Improve test coverage of SpecialDeletedContributions

https://gerrit.wikimedia.org/r/1059912

Change #1059344 merged by jenkins-bot:

[mediawiki/core@master] Extend ContributionsPager from DeletedContribsPager

https://gerrit.wikimedia.org/r/1059344

Change #1059912 merged by jenkins-bot:

[mediawiki/core@master] Improve test coverage of SpecialDeletedContributions

https://gerrit.wikimedia.org/r/1059912

Change #1058653 merged by jenkins-bot:

[mediawiki/core@master] Extend ContributionsSpecialPage from SpecialDeletedContributions

https://gerrit.wikimedia.org/r/1058653

Change #1060126 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Update release notes with changes to DeletedContribsPager hooks

https://gerrit.wikimedia.org/r/1060126

Change #1060126 merged by jenkins-bot:

[mediawiki/core@master] Update release notes with changes to DeletedContribsPager hooks

https://gerrit.wikimedia.org/r/1060126

kostajh subscribed.

As far as I can tell, this task is done. There is one open follow-up: T372611: Deleted revisions show incorrect byte count diffs