| Jdlrobson | |
| Jul 18 2024, 6:33 PM |
| F57640675: Screen Shot 2024-10-24 at 3.35.54 PM.png | |
| Oct 24 2024, 10:42 PM |
| F57640672: Screen Shot 2024-10-24 at 3.28.46 PM.png | |
| Oct 24 2024, 10:42 PM |
| F57640669: Screen Shot 2024-10-24 at 3.27.52 PM.png | |
| Oct 24 2024, 10:42 PM |
| F57640667: Screen Shot 2024-10-24 at 3.28.12 PM.png | |
| Oct 24 2024, 10:42 PM |
| F57617011: image.png | |
| Oct 15 2024, 3:02 PM |
| F57616963: image.png | |
| Oct 15 2024, 2:48 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Tip popup after confirming my e-mail for my account is still in light mode
The text says: "Welcome to your homepage! You can always click on your username to return here. ..."
What should have happened instead?:
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| support dark-mode by using tokens for colors and cdx-button for close | mediawiki/extensions/GuidedTour | master | +18 -34 |
Not sure which popup this task is about. The email-confirmed one looks fine. On enwiki:
Steps to verify:
mw.notify( mw.msg( 'confirmemail_loggedin' ), { // HACK: Not one of the supported types, but let's us add a class we can target type: 'ge-homepage-confirmemail' } );
Though, this has very different text than what is mentioned in the description. But I can't seem to find that copy anywhere in i18n files or in a MediaWiki: namespace?
Turns out this is about the homepage_welcome guided tour:
The problem can be reproduced at https://en.wikipedia.org/w/index.php?title=Special:Homepage&tour=homepage_welcome
h/t to @Urbanecm_WMF for pointing me to it.
Change #1080353 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/GuidedTour@master] support dark-mode by using tokens for colors and cdx-button for close
Change #1080353 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] support dark-mode by using tokens for colors and cdx-button for close
Checked on testwiki wmf.28 - checked new account creation (Homepage guided tour) / email confiramtion - all fixes are in place:
 |  |  |  |