Page MenuHomePhabricator

After confirming my email for my account, popup illegible.
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enable dark mode
  • Visit Special:Homepage
  • Confirm email

What happens?:
Tip popup after confirming my e-mail for my account is still in light mode

The text says: "Welcome to your homepage! You can always click on your username to return here. ..."

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
KStoller-WMF set the point value for this task to 2.Sep 17 2024, 2:43 PM

Not sure which popup this task is about. The email-confirmed one looks fine. On enwiki:

image.png (125×357 px, 6 KB)

Steps to verify:

  1. Enable dark mode
  2. go to your homepage
  3. paste the following code into the browser console:
modules/ext.growthExperiments.Homepage.ConfirmEmailNotice/index.js
mw.notify(
	mw.msg( 'confirmemail_loggedin' ),
	{
		// HACK: Not one of the supported types, but let's us add a class we can target
		type: 'ge-homepage-confirmemail'
	}
);

Though, this has very different text than what is mentioned in the description. But I can't seem to find that copy anywhere in i18n files or in a MediaWiki: namespace?

Michael added a subscriber: Urbanecm_WMF.

Turns out this is about the homepage_welcome guided tour:

image.png (234×546 px, 18 KB)

The problem can be reproduced at https://en.wikipedia.org/w/index.php?title=Special:Homepage&tour=homepage_welcome

h/t to @Urbanecm_WMF for pointing me to it.

Change #1080353 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GuidedTour@master] support dark-mode by using tokens for colors and cdx-button for close

https://gerrit.wikimedia.org/r/1080353

Change #1080353 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] support dark-mode by using tokens for colors and cdx-button for close

https://gerrit.wikimedia.org/r/1080353

Etonkovidova subscribed.

Checked on testwiki wmf.28 - checked new account creation (Homepage guided tour) / email confiramtion - all fixes are in place:

Screen Shot 2024-10-24 at 3.28.12 PM.png (712×1 px, 126 KB)
Screen Shot 2024-10-24 at 3.27.52 PM.png (594×1 px, 126 KB)
Screen Shot 2024-10-24 at 3.28.46 PM.png (594×2 px, 104 KB)
Screen Shot 2024-10-24 at 3.35.54 PM.png (326×1 px, 48 KB)