assertValidPGN() throws an exception if braced comments span two or more lines
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Wugapodes
	Jul 19 2024, 5:56 AM

Description

Steps to replicate the issue:

<pgn>
[Event "Chess Game"]
[Result "1-0"]

1. e4 {this comment
spans two lines} e5
</pgn>

What happens?:
ChessBrowser throws an exception. I've tracked it down to assertValidPGN().

What should have happened instead?:
A board should have been created or a more helpful error message should have been shown.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

	Subject	Repo	Branch	Lines +/-
	assertValidPGN() validates two-line brace comments	mediawiki/extensions/ChessBrowser	master	+48 -1

Status	Subtype	Assigned	Task
Open		None	T239440 Improve ChessBrowser interface
Open		None	T287990 Make ChessBrowser's user-facing error reporting more specific
Resolved	BUG REPORT	Wugapodes	T370499 assertValidPGN() throws an exception if braced comments span two or more lines

Change #1055319 had a related patch set uploaded (by Wugapodes; author: Wugapodes):

[mediawiki/extensions/ChessBrowser@master] [WIP] Multi-line brace comments validate

Wugapodes changed the task status from Open to In Progress.Jul 19 2024, 6:27 AM

Wugapodes claimed this task.

Wugapodes triaged this task as High priority.

Change #1055319 merged by jenkins-bot:

[mediawiki/extensions/ChessBrowser@master] assertValidPGN() validates two-line brace comments

Wugapodes closed this task as Resolved.Jul 21 2024, 9:38 PM