IP information could not be retrieved
Closed, ResolvedPublicBUG REPORT
Actions

Description

Today, IP information cannot display any content, and the message "IP information could not be retrieved" is displayed.

This problem occurs in enwiki, zhwiki, and commonswiki. (Maybe all wiki)

CI for IPInfo fails with:

16:13:50 There was 1 failure:
16:13:50 
16:13:50 1) MediaWiki\IPInfo\Test\Unit\Rest\Handler\IPInfoHandlerTest::testValidateBodyParams with data set "token parameter" (MediaWiki\Rest\RequestData Object (...), array('kittens'))
16:13:50 Failed asserting that two arrays are identical.
16:13:50 --- Expected
16:13:50 +++ Actual
16:13:50 @@ @@
16:13:50 -Array &0 (
16:13:50 -    'token' => 'kittens'
16:13:50 -)
16:13:50 +Array &0 ()

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
zuul: Add IPInfo to gate	integration/config	master	+2 -0
IPInfoHandler: Move token param definition to getBodyParamSettings	mediawiki/extensions/IPInfo	wmf/1.43.0-wmf.14	+7 -5
IPInfoHandler: Move token param definition to getBodyParamSettings	mediawiki/extensions/IPInfo	master	+7 -5

Customize query in gerrit

Related Objects

Mentioned In: T373069: IPInfo includes log.js from a non-existent file reference
T370613: ipinfo-widget-error-default shows up
T363118: "The IP information could not be retrieved"
Mentioned Here: rMW2b31f4c46ff8: param-settings: Remove backward compatibility code from default
T367394: REST: Stop using getParamSettings for body parameters
T363118: "The IP information could not be retrieved"
T370436: Puppet failure on deploy-1006.devtools.eqiad1.wikimedia.cloud - Not authorized to call search on /file_metadata/volatile/GeoIP

Event Timeline

Shizhao created this task.Jul 19 2024, 8:02 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptJul 19 2024, 8:02 AM

Johannnes89 subscribed.Jul 19 2024, 9:18 AM

Count_Count subscribed.Jul 19 2024, 12:33 PM

Titore subscribed.Jul 19 2024, 12:50 PM

Titore added a project: Regression.Jul 19 2024, 12:53 PM

Josve05a changed the subtype of this task from "Task" to "Bug Report".Jul 19 2024, 2:50 PM

I wonder if the puppet changes for T370436 did it. cc @Dzahn

Maybe it's the CrowdStrike incident/outage?
https://en.wikipedia.org/wiki/2024_CrowdStrike_incident

Same here, I can't access it either.

@JJMC89 No, I don't see a relation there.

That change merely gives the option to skip pulling geoip data from puppetmasters but the default stayed TRUE. You had to specifically set a Hiera key to disable it.

I also compiled that on the entire class AND ran puppet manually on a bunch of appservers. It was no change anywhere.

Finally the geoIP databases are there as always on the puppetmaster and on a random appserver I double checked.

I would refer to T363118 instead.

As suggested in T363118#9734804 I looked at the browser console and I noticed that this request returns a 403.

https://en.wikipedia.org/w/rest.php/ipinfo/v0/revision/1220150524?dataContext=infobox&language=en

errorKey	"rest-badtoken"
messageTranslations	
en	"The <var>token</var> parameter is required unless using a CSRF-safe authentication method."
httpCode	403
httpReason	"Forbidden"

Dzahn mentioned this in T363118: "The IP information could not be retrieved".Jul 19 2024, 6:33 PM

Perhaps related to some REST framework refactoring in core.

The tests seem to correctly diagnose this error: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/27499/console

Perhaps we need to add IP Info into the gate, so it would block CI and then be fixed before it reached wikis?

I suspect the fix is to move the handler definition code into a ::getBodyParamSettings definition.

git bisect says this was caused by T367394: REST: Stop using getParamSettings for body parameters / rMW2b31f4c46ff8: param-settings: Remove backward compatibility code from default.

Shizhao added a project: User-notice.Jul 22 2024, 2:49 AM

Change #1055652 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] zuul: Add IPInfo to gate

https://gerrit.wikimedia.org/r/1055652

gerritbot added a project: Patch-For-Review.Jul 22 2024, 5:07 AM

kostajh updated the task description. (Show Details)Jul 22 2024, 5:07 AM

Kizule mentioned this in T370613: ipinfo-widget-error-default shows up.Jul 22 2024, 5:23 AM

Kizule merged a task: T370613: ipinfo-widget-error-default shows up.

Kizule subscribed.

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed Trust and Safety Product Sprint.Jul 22 2024, 5:31 AM

kostajh claimed this task.Jul 22 2024, 5:39 AM

Change #1055655 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPInfo@master] IPInfoHandler: Override getBodyValidator

https://gerrit.wikimedia.org/r/1055655

Change #1055655 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPInfoHandler: Move token param definition to getBodyParamSettings

https://gerrit.wikimedia.org/r/1055655

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 22 2024, 7:00 AM

Change #1055771 had a related patch set uploaded (by STran; author: Kosta Harlan):

[mediawiki/extensions/IPInfo@wmf/1.43.0-wmf.14] IPInfoHandler: Move token param definition to getBodyParamSettings

https://gerrit.wikimedia.org/r/1055771

Change #1055771 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@wmf/1.43.0-wmf.14] IPInfoHandler: Move token param definition to getBodyParamSettings

https://gerrit.wikimedia.org/r/1055771

Mentioned in SAL (#wikimedia-operations) [2024-07-22T07:23:22Z] <stran@deploy1002> Started scap sync-world: Backport for [[gerrit:1055771|IPInfoHandler: Move token param definition to getBodyParamSettings (T370500)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-22T07:25:44Z] <stran@deploy1002> stran: Backport for [[gerrit:1055771|IPInfoHandler: Move token param definition to getBodyParamSettings (T370500)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-22T07:35:40Z] <stran@deploy1002> Finished scap: Backport for [[gerrit:1055771|IPInfoHandler: Move token param definition to getBodyParamSettings (T370500)]] (duration: 12m 18s)