Page MenuHomePhabricator

Add logging to Citoid's "Add manually" call to action
Closed, ResolvedPublic

Description

NOTE: work on this task is blocked on approval through the Research and Decision Science Requests Process

T364595 introduced a new instance of the Add manually call to action:

CitoidError_ManualAdd.png (1,696×1,524 px, 362 KB)

This task involves the working of instrumentation to said affordance so that we can measure and understand who engages with it and how they engage with it.

Event Timeline

Change #1057915 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/Citoid@master] Log when the add-manually button in the error message is pressed

https://gerrit.wikimedia.org/r/1057915

DLynch moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Sequence will be:

featureactionmeaning
citoidwindow-open-from-commandInspector opens
citoidautomatic-generate"create" button clicked
CitoidInspectorautomatic-generate-fail-searchResultsfailure happened when getting the search results (added in T363292)
citoidautomatic-generate-failfailure happened, error message shown (added in T363292)
citoidautomatic-generate-manual-fallback"add manually" button clicked (added by this patch)
citoidpanel-switchswitching panels
citoidpanel-switch-manualswitching to the manual panel
citoiddialog-manual-chooseclicked a button in the manual panel
referencewindow-open-from-commandbase cite reference-editor opens

I didn't put it under automatic-generate-fail because WMDE seems to be using that prefix for logging error-reasons in T363292.

Patch also fixes a minor bug that would cause the panel-switch+panel-switch-manual events to fire twice when the "add manually" button was pressed.

@MNeisler, I'm assigning this ticket over to you to +1 or suggest any changes to the instrumentation @DLynch proposed in T370561#10023765 (see bolded bit).

The proposed new event (automatic-generate-manual-fallback) and the sequence of events noted in T370561#10023765 looks good to me. No changes.

@DLynch - Let me know once this has been deployed and I can do a quick QA check.

Change #1057915 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Log when the add-manually button in the error message is pressed

https://gerrit.wikimedia.org/r/1057915