Page MenuHomePhabricator
Create Task
Maniphest T370577

EntitySchema CI broken: Cannot create an actor for an IP user when temporary accounts are enabled
Closed, ResolvedPublic
Actions

Description

Seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/1055521:

13:18:22 2) EntitySchema\Tests\Integration\MediaWiki\Specials\NewEntitySchemaTest::testNewSchemaIsCreatedWithMinData
13:18:22 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
13:18:22 
13:18:22 /workspace/src/includes/user/ActorStore.php:638
13:18:22 /workspace/src/includes/user/ActorStore.php:415
13:18:22 /workspace/src/includes/Revision/RevisionStore.php:891
13:18:22 /workspace/src/includes/Revision/RevisionStore.php:768
13:18:22 /workspace/src/includes/Revision/RevisionStore.php:634
13:18:22 /workspace/src/includes/Revision/RevisionStore.php:485
13:18:22 /workspace/src/includes/libs/rdbms/database/Database.php:2276
13:18:22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:127
13:18:22 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:665
13:18:22 /workspace/src/includes/Revision/RevisionStore.php:493
13:18:22 /workspace/src/includes/Storage/PageUpdater.php:1515
13:18:22 /workspace/src/includes/Storage/PageUpdater.php:935
13:18:22 /workspace/src/extensions/EntitySchema/src/DataAccess/MediaWikiRevisionEntitySchemaInserter.php:135
13:18:22 /workspace/src/extensions/EntitySchema/src/DataAccess/MediaWikiRevisionEntitySchemaInserter.php:102
13:18:22 /workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:121
13:18:22 /workspace/src/includes/htmlform/HTMLForm.php:793
13:18:22 /workspace/src/includes/htmlform/HTMLForm.php:674
13:18:22 /workspace/src/extensions/EntitySchema/src/MediaWiki/Specials/NewEntitySchema.php:85
13:18:22 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:120
13:18:22 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:50
13:18:22 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:75
13:18:22 /workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/NewEntitySchemaTest.php:77
13:18:22 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Temporarily disable IP Masking (temporary accounts) in CI"mediawiki/extensions/EntitySchemamaster+0 -23
Temporarily disable IP Masking (temporary accounts) in CImediawiki/extensions/EntitySchemamaster+23 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.Jul 20 2024, 10:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2024, 10:20 AM
Maintenance_bot added a project: Wikidata.Jul 20 2024, 10:29 AM
Lucas_Werkmeister_WMDE subscribed.Jul 22 2024, 9:33 AM

Apparently this isn’t limited to the tests – we actually didn’t implement temporary account creation on Special:NewEntitySchema yet.

image.png (1×1 px, 414 KB)

We removed the warning about IP addresses in T352005, but T356148 was closed without being done (probably due to a misunderstanding).

karapayneWMDE subscribed.Jul 22 2024, 9:42 AM

This will be handled in our [now reopened] ticket: https://phabricator.wikimedia.org/T356148

karapayneWMDE added a parent task: T356148: Adjust EntitySchema Special Pages to not leak IPs when editing and IP masking is enabled.Jul 22 2024, 9:43 AM
gerritbot added a comment.Jul 24 2024, 9:52 AM

Change #1056200 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Temporarily disable IP Masking (temporary accounts) in CI

https://gerrit.wikimedia.org/r/1056200

gerritbot added a project: Patch-For-Review.Jul 24 2024, 9:52 AM
gerritbot added a comment.Jul 31 2024, 3:32 PM

Change #1058628 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Revert "Temporarily disable IP Masking (temporary accounts) in CI"

https://gerrit.wikimedia.org/r/1058628

gerritbot added a comment.Aug 6 2024, 7:41 AM

Change #1056200 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Temporarily disable IP Masking (temporary accounts) in CI

https://gerrit.wikimedia.org/r/1056200

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 6 2024, 8:00 AM
gerritbot added a comment.Aug 13 2024, 9:40 AM

Change #1058628 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Revert "Temporarily disable IP Masking (temporary accounts) in CI"

https://gerrit.wikimedia.org/r/1058628

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 13 2024, 9:45 AM
Lucas_Werkmeister_WMDE claimed this task.

I think we can resolve this directly – CI is fixed, and whatever happens with T356148: Adjust EntitySchema Special Pages to not leak IPs when editing and IP masking is enabled, we’ll have to ensure it stays green in order to be able to merge further changes at all.

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 13 2024, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2024, 10:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits