Page MenuHomePhabricator
Create Task
Maniphest T370585

Reference numbering appears incorrectly in arwiki (due to ignoring wgTranslateNumerals)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • The problem only appears in the visual editor.

What happens?:
Reference numbering shows Eastern Arabic numerals and with a zero (eg [0][١]).

What should have happened instead?:
Western Arabic numerals are supposed to appear without a zero (eg [1]).

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Screenshot from 2024-07-20 22-45-36.png (221×749 px, 26 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Respect wgTranslateNumerals in Cite footnote markersmediawiki/extensions/Citewmf/1.43.0-wmf.15+2 -1
Respect wgTranslateNumerals in Cite footnote markersmediawiki/extensions/Citewmf/1.43.0-wmf.14+2 -1
Respect wgTranslateNumerals in Cite footnote markersmediawiki/extensions/Citemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Gerges created this task.Jul 20 2024, 7:55 PM
Restricted Application added subscribers: alaa, Aklapper. · View Herald TranscriptJul 20 2024, 7:55 PM
Gerges updated the task description. (Show Details)Jul 20 2024, 7:56 PM
DLynch added a project: Content-Transform-Team.Jul 20 2024, 8:05 PM
Gerges mentioned this in T247921: Ensure subreferences displayed in VE are visually consistent with read mode.Jul 20 2024, 8:15 PM
IZapico-WMF subscribed.Jul 21 2024, 11:24 AM

This is also happening in eswiki.

image.png (264×554 px, 47 KB)

Aklapper closed this task as a duplicate of T370512: Some wikis append a 0 (zero) after every reference/footnote in VisualEditor (due to local CSS).Jul 21 2024, 12:18 PM
awight reopened this task as Open.Jul 23 2024, 1:09 PM
awight subscribed.

Reopening because the cause and solution are different than in the other, closely related bug.

gerritbot added a comment.Jul 23 2024, 1:09 PM

Change #1056153 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056153

gerritbot added a project: Patch-For-Review.Jul 23 2024, 1:09 PM
awight added projects: WMDE-TechWish-Sprint-2024-07-10, Unplanned-Sprint-Work.Jul 23 2024, 1:11 PM
Aklapper renamed this task from Reference numbering appears incorrectly in arwiki to Reference numbering appears incorrectly in arwiki (due to ignoring wgTranslateNumerals).Jul 23 2024, 1:21 PM
Aklapper merged a task: T370634: Reference numbering in VE ignores wgTranslateNumerals (appears as Eastern Arabic numerals instead of Western Arabic).
gerritbot added a comment.Jul 23 2024, 5:12 PM

Change #1056204 had a related patch set uploaded (by WMDE-Fisch; author: Awight):

[mediawiki/extensions/Cite@wmf/1.43.0-wmf.14] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056204

gerritbot added a comment.Jul 23 2024, 5:12 PM

Change #1056205 had a related patch set uploaded (by WMDE-Fisch; author: Awight):

[mediawiki/extensions/Cite@wmf/1.43.0-wmf.15] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056205

gerritbot added a comment.Jul 23 2024, 5:34 PM

Change #1056153 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056153

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 23 2024, 6:00 PM
gerritbot added a comment.Jul 23 2024, 8:43 PM

Change #1056204 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.43.0-wmf.14] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056204

gerritbot added a comment.Jul 23 2024, 8:43 PM

Change #1056205 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.43.0-wmf.15] Respect wgTranslateNumerals in Cite footnote markers

https://gerrit.wikimedia.org/r/1056205

Stashbot added a comment.Jul 23 2024, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-23T20:44:08Z] <tgr@deploy1002> Started scap sync-world: Backport for [[gerrit:1056204|Respect wgTranslateNumerals in Cite footnote markers (T370585)]], [[gerrit:1056205|Respect wgTranslateNumerals in Cite footnote markers (T370585)]]

Stashbot added a comment.Jul 23 2024, 8:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-23T20:46:26Z] <tgr@deploy1002> wmde-fisch, tgr: Backport for [[gerrit:1056204|Respect wgTranslateNumerals in Cite footnote markers (T370585)]], [[gerrit:1056205|Respect wgTranslateNumerals in Cite footnote markers (T370585)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 23 2024, 8:53 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-23T20:53:43Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:1056204|Respect wgTranslateNumerals in Cite footnote markers (T370585)]], [[gerrit:1056205|Respect wgTranslateNumerals in Cite footnote markers (T370585)]] (duration: 09m 34s)

WMDE-Fisch moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2024-07-10 board.Jul 23 2024, 8:57 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.15; 2024-07-23); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 23 2024, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 23 2024, 9:30 PM
WMDE-Fisch closed this task as Resolved.Jul 24 2024, 2:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits