Page MenuHomePhabricator

Provide an easy way to get a diff against an old revision of a page while editing it
Open, LowPublic

Description

Suppose someone makes a big change on page Foo or Template:Bar, and gets reverted because some other user found a problem in the new revision. The first user may want to improve its original change, and to do that, he/she may open his/her old version from the page history (i.e., oldid=12345) and then open that old revision for edit (oldid=12345&action=edit).
Once the updates are finished, though, there is no way to get a diff of what he/she changed since the last try. He/she will need to save the page first, and only then to get a diff.

So, I think it would be good to provide a new button [Show changes since this old revision] on the right side of the existing [Show changes], when editing an old version of a page.

See Also:

Details

Reference
bz35067

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:19 AM
bzimport set Reference to bz35067.
  • Bug 41307 has been marked as a duplicate of this bug. ***

This should be easy since the difference between the two features is exactly what is shown on gerrit change 30113:
https://gerrit.wikimedia.org/r/#/c/30113/1/includes/EditPage.php,unified

Copying from bug 41307:

If a user open an old revision of a page in edit mode and then click on [Show
changes], it will be displayed a diff against the most recent version of the
page and not against the version he was editing (sometimes it is this diff
which the user wants).

Such a feature is available in [[User:Js/ajaxPreview#Extra_features]], and is
very useful.

See also bug 29674.

(In reply to PiRSquared17 from comment #4)

Doesn't "undo" give a diff?

If I go to
https://en.wikipedia.org/Wikipedia:Sandbox?action=edit&oldid=605309723
and change "Test 1" to "Test 3", there is no "undo" feature which I could use to get a diff (and the button "Show changes" will make a diff against the most recent version of the page, which is not what I want).

Change 135165 had a related patch set uploaded by devunt:
Add "Show changes against previous revision" button

https://gerrit.wikimedia.org/r/135165

He7d3r set Security to None.
Aklapper lowered the priority of this task from Medium to Low.Aug 10 2019, 4:32 PM

Unrelated to the History or Diff pages themselves but about a button when editing a page, hence removing tag.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/135165/ has been abandoned, hence removing Patch-For-Review.

@devunt: This task has been assigned to you a while ago. Do you still plan to work on this task, or do you need any help? If this task is not resolved and only if you do not plan to work on this task: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu). Thanks! :)

Aklapper added a subscriber: devunt.

@devunt: Hi, I'm resetting the task assignee due to inactivity. Please feel free to reclaim this task if you plan to work on this - it would be welcome! Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for more information - thanks!