Page MenuHomePhabricator
Create Task
Maniphest T370714

GlobalRename and move-subpages can move translatable pages without their components
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

On Meta-Wiki, the user "Patafisik" was renamed to "Una tantum". This moved the page https://meta.wikimedia.org/wiki/User:Patafisik/Wikicaches to https://meta.wikimedia.org/wiki/User:Una_tantum/Wikicaches and its translation subpages, without moving any of the tunits, which broke things horribly.

When I attempted to clean up the mess by removing the page from translation and then moving it back to the original name ticking "move subpages", the result was that subpages like https://meta.wikimedia.org/w/index.php?title=User:Patafisik/Wikicaches/Newbies&redirect=no were also moved, but not their translations or their tunits. This didn't break anything not already broken by the first move, but it could in a different context have caused the same bug.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Block manual moves of message bundles tooAbijeet Patromediawiki/extensions/Translatemleb-2026.01+11 -1
Block manual moves of message bundles tooPpperymediawiki/extensions/Translatemaster+11 -1
Block external attempts to move translatable pagesPpperymediawiki/extensions/Translatemaster+32 -0
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.Jul 22 2024, 8:11 PM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptJul 22 2024, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• larissagaulia moved this task from Inbox, needs triage to Within 2 Qs on the MediaWiki-Core-Platform-Team board.Jul 30 2024, 2:59 PM
abi_ triaged this task as Medium priority.Aug 8 2024, 8:17 AM
abi_ moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.
Pppery added a comment.Nov 10 2024, 4:04 AM

Happened again with https://meta.wikimedia.org/wiki/User:Revi_C./FAQ

Bugreporter moved this task from Backlog to GlobalRename / Vanishing on the MediaWiki-extensions-CentralAuth board.Dec 8 2024, 8:25 AM
JTweed-WMF edited projects, added: MediaWiki-Core-Platform-Team (Roadmap); removed: MediaWiki-Core-Platform-Team.Jan 22 2025, 3:52 PM
JTweed-WMF moved this task from Now => Move to Inbox to Later => Move to Inbox on the MediaWiki-Core-Platform-Team (Roadmap) board.
gerritbot added a comment.Nov 21 2025, 1:27 AM

Change #1208066 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] Block external attempts to move translatable pages

https://gerrit.wikimedia.org/r/1208066

gerritbot added a project: Patch-For-Review.Nov 21 2025, 1:27 AM
Pppery claimed this task.Nov 21 2025, 1:27 AM
Tacsipacsi subscribed.Nov 21 2025, 3:00 PM

Similar bug (but the fix will probably be completely different): T410746: Broken translatable pages can be moved without related pages.

• Nikerabbit added projects: LPL Essential (FY2025-26 Q2), LPL Projects (Other), Community-collaboration.Nov 22 2025, 7:55 AM
• Nikerabbit moved this task from Backlog to Ready for dev on the LPL Essential (FY2025-26 Q2) board.Nov 25 2025, 9:23 AM
abi_ moved this task from Ready for dev to Pending Deployment on the LPL Essential (FY2025-26 Q2) board.Nov 26 2025, 12:45 PM
abi_ subscribed.
In T370714#11394723, @gerritbot wrote:

Change #1208066 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] Block external attempts to move translatable pages

https://gerrit.wikimedia.org/r/1208066

With this patch applied, renaming a user that has translatable pages under the user page I see the following errors:

image.png (1,025×681 px, 92 KB)

The user rename worked but the translatable page was not moved.

gerritbot added a comment.Nov 26 2025, 1:09 PM

Change #1208066 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Block external attempts to move translatable pages

https://gerrit.wikimedia.org/r/1208066

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2025, 1:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Nov 26 2025, 2:00 PM
abi_ moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q2) board.Dec 3 2025, 3:26 PM
abi_ added a comment.Dec 7 2025, 5:13 PM

@Pppery Can you try renaming: https://meta.wikimedia.org/wiki/User:APatro_(WMF) that has translatable pages under it. It should no longer be possible.

Pppery added a comment.Dec 7 2025, 5:18 PM

Okay, I think that worked as I intended it to:

It moved the base page successfully (moving subpages is done after the base page move succeeds and never blocks the base page from being moved)

image.png (1,227×258 px, 115 KB)

It seems to have moved all of the nontranslatable subpages and produced warnings saying it couldn't move any translatable subpages.

I note it did move message bundles, though, like https://meta.wikimedia.org/wiki/User:APatro_(WMF)/2/MessageBundleDemoForever. Probably it shouldn't. I should write a follow-up for that.

gerritbot added a comment.Dec 7 2025, 5:49 PM

Change #1216191 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] Block manual moves of message bundles too

https://gerrit.wikimedia.org/r/1216191

gerritbot added a project: Patch-For-Review.Dec 7 2025, 5:49 PM
• Nikerabbit moved this task from Need QA to In Progress on the LPL Essential (FY2025-26 Q2) board.Dec 10 2025, 11:48 AM
• Nikerabbit set the point value for this task to 2.
• Nikerabbit subscribed.

Moving back as there is more to review.

abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q2) board.Dec 12 2025, 4:42 PM
gerritbot added a comment.Dec 12 2025, 5:02 PM

Change #1216191 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Block manual moves of message bundles too

https://gerrit.wikimedia.org/r/1216191

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2025, 5:31 PM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16); removed: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Dec 12 2025, 6:00 PM
Pppery removed projects: MediaWiki-Core-Platform-Team (Roadmap), MediaWiki-Page-rename, MediaWiki-User-rename, MediaWiki-extensions-CentralAuth.Dec 23 2025, 2:54 AM
abi_ moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q2) board.Jan 5 2026, 11:50 AM

@Pppery This should be ready for another round of testing. Message bundles should be handled too.

• Nikerabbit closed this task as Resolved.Jan 12 2026, 8:13 AM
• Nikerabbit moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q2) board.
gerritbot added a comment.Feb 19 2026, 8:10 AM

Change #1240594 had a related patch set uploaded (by Abijeet Patro; author: Pppery):

[mediawiki/extensions/Translate@mleb-2026.01] Block manual moves of message bundles too

https://gerrit.wikimedia.org/r/1240594

gerritbot added a project: Patch-For-Review.Feb 19 2026, 8:10 AM
gerritbot added a comment.Feb 19 2026, 10:48 AM

Change #1240594 merged by jenkins-bot:

[mediawiki/extensions/Translate@mleb-2026.01] Block manual moves of message bundles too

https://gerrit.wikimedia.org/r/1240594

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2026, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits