Page MenuHomePhabricator
Create Task
Maniphest T370740

"Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki
Open, LowPublicBUG REPORT
Actions

Description

Originally reported by User:4inHand

Steps to replicate the issue (include links if applicable):

  1. Go to https://en.wikipedia.org/wiki/Special:PendingChanges in an incognito window
  2. Click one of the articles
  3. Click "Download as PDF" button

What happens?:
It will go to Special:Book instead of Special:DownloadAsPdf. The error "The Book Creator doesn't support PDF rendering" will be displayed.

This bug only occurs when the user is logged out, and it still occurs in safemode.

What should have happened instead?:
It should go to Special:DownloadAsPdf.

Other information (browser name/version, screenshots, etc.):
All browsers (e.g. Firefox, Chrome)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ensure that the stable revision has a PDF linkmediawiki/extensions/ElectronPdfServicemaster+35 -3
Zuul: [mediawiki/extensions/ElectonPdfService] Add FlaggedRevs as dependencyintegration/configmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

SCP-2000 created this task.Jul 23 2024, 4:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2024, 4:29 AM
Dragoniez added a project: Electron-PDFs.Jul 25 2024, 10:52 AM
Dragoniez subscribed.

This is bizarre. This one seems to be relevant only to the project, article, and user type, and also the skin doesn't seem to make a difference. I tried importing the article to testwiki but couldn't reproduce the same issue.

TheDJ subscribed.Jul 25 2024, 2:16 PM

That definitely is quite strange...

Dragoniez added a project: FlaggedRevs.Jul 26 2024, 11:23 AM

I managed to identify the cause of the reported situation: pending changes.

This task is fundamentally the same as T306232, and when there are pending changes (that in one way or another only influence logged-out users), Electron thinks that the displayed page isn't the latest revision. Try visiting Special:PendingChanges on a wiki where FlaggedRevs is installed, choose a page in the list, go there, and you should be able to reproduce the same situation.

TheDJ mentioned this in T371147: Electron/Collection/Proton cleanup.Jul 26 2024, 8:59 PM
TheDJ closed this task as a duplicate of T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.Jul 26 2024, 11:08 PM
Tacsipacsi mentioned this in T306232: "Download as PDF" on an old revision goes to Special:Book rather than Special:DownloadAsPdf.Jul 28 2024, 12:31 PM
TheDJ reopened this task as Open.Aug 7 2024, 2:32 PM
gerritbot added a comment.Aug 7 2024, 2:36 PM

Change #1060455 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/ElectronPdfService@master] Ensure that the stable revision has a PDF link

https://gerrit.wikimedia.org/r/1060455

gerritbot added a project: Patch-For-Review.Aug 7 2024, 2:36 PM
gerritbot added a comment.Aug 7 2024, 3:47 PM

Change #1060462 had a related patch set uploaded (by TheDJ; author: TheDJ):

[integration/config@master] Add FlaggedRevs as dependency of ElectonPdfService

https://gerrit.wikimedia.org/r/1060462

Novem_Linguae renamed this task from "Download as PDF" button link to Special:Book instead of Special:DownloadAsPdf on dewiki to "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki.Aug 8 2024, 2:05 PM
Novem_Linguae updated the task description. (Show Details)
gerritbot added a comment.Aug 9 2024, 7:37 AM

Change #1060462 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/ElectonPdfService] Add FlaggedRevs as dependency

https://gerrit.wikimedia.org/r/1060462

Stashbot added a comment.Aug 9 2024, 7:38 AM

Mentioned in SAL (#wikimedia-releng) [2024-08-09T07:38:12Z] <James_F> Zuul: [mediawiki/extensions/ElectonPdfService] Add FlaggedRevs as dependency for T370740

Tacsipacsi subscribed.Aug 10 2024, 12:08 PM
gerritbot added a comment.Apr 20 2025, 7:29 PM

Change #1060455 abandoned by TheDJ:

[mediawiki/extensions/ElectronPdfService@master] Ensure that the stable revision has a PDF link

Reason:

not really working on this any longer

https://gerrit.wikimedia.org/r/1060455

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2025, 7:30 PM
Jdlrobson-WMF subscribed.May 23 2025, 11:28 PM

I can't replicate this issue.

Jdlrobson-WMF changed the task status from Open to Stalled.May 23 2025, 11:29 PM
Jdlrobson-WMF moved this task from Backlog to Triaged (PHP) on the Collection board.
Jdlrobson-WMF triaged this task as Low priority.May 23 2025, 11:31 PM
1AmNobody24 subscribed.May 27 2025, 12:35 PM

This isn't limited to dewiki. I can replicate it on enwiki with all pages listed on Special:PendingChanges. I assume it affects all wikis that use FlaggedRevs.

Jdlrobson-WMF changed the task status from Stalled to Open.May 28 2025, 11:21 PM
Jdlrobson-WMF updated the task description. (Show Details)
TheDJ mentioned this in T224922: Code Stewardship Review: Collection Extension.Jun 26 2025, 10:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits