Page MenuHomePhabricator
Create Task
Maniphest T370743

Make IP reveal work on Special:DeletedContributions
Closed, ResolvedPublic
Actions

Description

Background

Special:DeletedContributions shows a user's contributions from pages that were deleted. Like Special:Contributions, a temporary user's deleted contributions page might have many entries, from different IP addresses.

IP reveal buttons are added to Special:Contributions, so they should be added to Special:DeletedContributions too.

Technical background

IP reveal buttons are added to most pages wherever there are temporary user links. They are currently not added to Special:DeletedContributions because there are no user links. There are no user links on Special:Contributions either, but CheckUser has some custom code to add buttons to Special:Contributions.

This currently can't be re-used for Special:DeletedContributions because the HTML structure is quite different.

What needs doing

After T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions, it should be possible to add IP reveal buttons to Special:DeletedContributions by loading temporaryaccount/SpecialContributions.js (with minimal modifications) from dispatcher.js.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable IP Reveal buttons on Special:DeletedContributionsmediawiki/extensions/CheckUsermaster+59 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Jul 23 2024, 6:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2024, 6:30 AM
Tchanders added a subtask: T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions.Jul 23 2024, 6:31 AM
Tchanders added a parent task: T325238: [Epic] IP Address Reveal for Privileged Users.
STran claimed this task.Jul 23 2024, 1:46 PM
STran moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 24 2024, 12:02 PM

Change #1056483 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Enable IP Reveal buttons on Special:DeletedContributions

https://gerrit.wikimedia.org/r/1056483

gerritbot added a project: Patch-For-Review.Jul 24 2024, 12:02 PM
STran moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 24 2024, 1:39 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 24 2024, 3:01 PM
gerritbot added a comment.Jul 24 2024, 3:31 PM

Change #1056483 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Enable IP Reveal buttons on Special:DeletedContributions

https://gerrit.wikimedia.org/r/1056483

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 24 2024, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 4:30 PM
Djackson-ctr subscribed.Jul 25 2024, 1:31 AM

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (1,014×458 px, 31 KB)
image.png (1,015×466 px, 31 KB)

Dreamy_Jazz closed this task as Resolved.Jul 25 2024, 8:21 AM
Dreamy_Jazz moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
kostajh closed subtask T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions as Resolved.Aug 20 2024, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits