Page MenuHomePhabricator

Filter temporary accounts correctly on ApiQueryRecentChanges
Closed, ResolvedPublic

Description

Similarly to T370695: Temporary accounts are treated as registered users in non-JavaScript RecentChanges/Watchlist, treat temporary users the same as anonymous (IP) users when filtering on the RecentChanges API.

This will involve updating ApiQueryRecentChanges.

  • Including rcshow=anon should return changes by IP users and temporary accounts
  • Including rcshow=!anon should return changes by named users

Event Timeline

ApiQueryWatchlist, ApiFeedRecentChanges, and ApiFeedWatchlist also have anon/!anon or hideanons options.

Thanks @Nardog.

Looks like ApiQueryWatchlist and ApiFeedRecentChanges should have been fixed in T341228: Update action API to handle temporary users.

We should look into ApiFeedWatchlist - seems to have also been missed.

Change #1056514 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] [WIP] Filter temporary accounts as anonymous in ApiQueryRecentChanges

https://gerrit.wikimedia.org/r/1056514

Does this task also cover ApiFeedWatchlist? anon/!anon seem to be already working correctly.

Thanks @Nardog.

Looks like ApiQueryWatchlist and ApiFeedRecentChanges should have been fixed in T341228: Update action API to handle temporary users.

We should look into ApiFeedWatchlist - seems to have also been missed.

ApiFeedWatchlist seems to be working, but ApiFeedRecentChanges does not:

Thanks @Nardog.

Looks like ApiQueryWatchlist and ApiFeedRecentChanges should have been fixed in T341228: Update action API to handle temporary users.

We should look into ApiFeedWatchlist - seems to have also been missed.

ApiFeedWatchlist seems to be working, but ApiFeedRecentChanges does not:

Based on my reading of the code, it seems that feedrecentchanges has been fixed through T370695.

Change #1056514 merged by jenkins-bot:

[mediawiki/core@master] Filter temporary accounts as anonymous in ApiQueryRecentChanges

https://gerrit.wikimedia.org/r/1056514

Thanks for looking into the APIs @Nardog.

ApiFeedWatchlist seems to be working, but ApiFeedRecentChanges does not:

This seems to contain no temp accounts...

...whereas this contains temp accounts. I believe that's correct, or am I missing something?

Thanks for looking into the APIs @Nardog.

ApiFeedWatchlist seems to be working, but ApiFeedRecentChanges does not:

This seems to contain no temp accounts...

...whereas this contains temp accounts. I believe that's correct, or am I missing something?

The former contained temp accounts as I recall, though it currently does not.

The latter is completely empty when I'm logged in:

<?xml version="1.0"?>
<rss version="2.0" xmlns:dc="http://purl.org/dc/elements/1.1/">
	<channel>
		<title>Wikipedia  - Recent changes [en]</title>
		<link>https://test.wikipedia.org/wiki/Special:RecentChanges</link>
		<description>Track the most recent changes to the wiki in this feed.</description>
		<language>en</language>
		<generator>MediaWiki 1.43.0-wmf.15</generator>
		<lastBuildDate>Mon, 29 Jul 2024 21:13:38 GMT</lastBuildDate>
</channel></rss>

When I'm logged off, it does contain temp accounts. The only checked item in "Recent changes" -> "Changed shown" in Preferences is "Hide categorization of pages", which I believe is the default. But I don't think feeds should give you different results depending on whether you're logged in, nor are they supposed to, right? Wonder if it's a CDN issue or something, though FWIW the header says codfw.

Djackson-ctr subscribed.

Per the Ticket Description I have verified the new code has been implemented and is working as expected for APIQueryRecentChanges.

Thanks for looking into the APIs @Nardog.

ApiFeedWatchlist seems to be working, but ApiFeedRecentChanges does not:

This seems to contain no temp accounts...

...whereas this contains temp accounts. I believe that's correct, or am I missing something?

The former contained temp accounts as I recall, though it currently does not.

The latter is completely empty when I'm logged in:

<?xml version="1.0"?>
<rss version="2.0" xmlns:dc="http://purl.org/dc/elements/1.1/">
	<channel>
		<title>Wikipedia  - Recent changes [en]</title>
		<link>https://test.wikipedia.org/wiki/Special:RecentChanges</link>
		<description>Track the most recent changes to the wiki in this feed.</description>
		<language>en</language>
		<generator>MediaWiki 1.43.0-wmf.15</generator>
		<lastBuildDate>Mon, 29 Jul 2024 21:13:38 GMT</lastBuildDate>
</channel></rss>

When I'm logged off, it does contain temp accounts. The only checked item in "Recent changes" -> "Changed shown" in Preferences is "Hide categorization of pages", which I believe is the default. But I don't think feeds should give you different results depending on whether you're logged in, nor are they supposed to, right? Wonder if it's a CDN issue or something, though FWIW the header says codfw.

I see no difference between the response from those links whether I'm logged in or logged out.

These are my relevant preferences:
{F56783197}

Fixed on my end too, must have been a temporary issue.

Thanks everyone, I think we can close this.