Page MenuHomePhabricator
Create Task
Maniphest T370832

📛 Replace `sitelink-conflict` error with `data-policy-violation`
Closed, ResolvedPublic
Actions

Description

The new error should follow this format:

HTTP status code: 422
"code":"data-policy-violation"
"message":"Edit violates data policy"
"context":{ "violation": "{violation}", "violation_context": { "some": "context" } }

Note:

  • remember to check if the OAS needs updating as well.
  • {violation} is one of the existing error codes (see main ticket, minus patch-result- errors)
  • {violation_context} includes the illegal context, e.g. { "language-code": "foo" }

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Replace `sitelink-conflict` error with `data-policy-violation`mediawiki/extensions/Wikibasemaster+93 -62
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dima_Koushha_WMDE created this task.Jul 23 2024, 9:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2024, 9:36 PM
Dima_Koushha_WMDE updated the task description. (Show Details)Jul 23 2024, 9:38 PM
Ollie.Shotton_WMDE claimed this task.Jul 30 2024, 1:00 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 25) board.
Ollie.Shotton_WMDE removed Ollie.Shotton_WMDE as the assignee of this task.Jul 30 2024, 1:11 PM
Ollie.Shotton_WMDE moved this task from Doing to To Do on the Wikibase Reuse Team (Sprint 25) board.
Ollie.Shotton_WMDE subscribed.
• Muhammad_Yasser_Jazirahly_WMDE claimed this task.Jul 31 2024, 2:07 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 25) board.
gerritbot added a comment.Jul 31 2024, 4:15 PM

Change #1058640 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Replace `sitelink-conflict` error with `data-policy-violation`

https://gerrit.wikimedia.org/r/1058640

gerritbot added a project: Patch-For-Review.Jul 31 2024, 4:15 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 25) board.Jul 31 2024, 6:23 PM
gerritbot added a comment.Aug 5 2024, 1:52 PM

Change #1058640 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Replace `sitelink-conflict` error with `data-policy-violation`

https://gerrit.wikimedia.org/r/1058640

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 5 2024, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2024, 2:30 PM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 25) board.Aug 5 2024, 3:21 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Aug 6 2024, 10:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits