Page MenuHomePhabricator

Miss-leading migration error message
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Run the migration script in a wiki which has migration schemas with missing SCHEMA_NEXT_VERSION
sgimeno@deployment-mwmaint03:~$ foreachwiki extensions/CommunityConfiguration/maintenance/migrateConfig.php --dry-run CommunityUpdates

-----------------------------------------------------------------
arwiki
-----------------------------------------------------------------
LogicException from line 86 of /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Schema/SchemaMigrator.php: GrowthExperiments/Config/Schemas/CommunityUpdatesSchema/2.0.2 does not have a next/previous version linked.
#0 /srv/mediawiki/php-master/extensions/CommunityConfiguration/src/Schema/SchemaMigrator.php(46): MediaWiki\Extension\CommunityConfiguration\Schema\SchemaMigrator->doConvertDataToVersion(Object(MediaWiki\Extension\CommunityConfiguration\Validation\JsonSchemaValidator), Object(stdClass), '2.0.0', '2.0.2')
#1 /srv/mediawiki/php-master/extensions/CommunityConfiguration/maintenance/migrateConfig.php(83): MediaWiki\Extension\CommunityConfiguration\Schema\SchemaMigrator->convertDataToVersion(Object(MediaWiki\Extension\CommunityConfiguration\Provider\DataProvider), '2.0.2')
#2 /srv/mediawiki/php-master/maintenance/includes/MaintenanceRunner.php(696): MediaWiki\Extension\CommunityConfiguration\Maintenance\MigrateConfig->execute()
#3 /srv/mediawiki/php-master/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#4 /srv/mediawiki/multiversion/MWScript.php(158): require_once('/srv/mediawiki/...')
#5 {main}

What happens?:

The error points to a wrong schema, the latest, which is not the schema actually missing SCHEMA_NEXT_VERSION

What should have happened instead?:
The error should point to the right schema missing SCHEMA_NEXT_VERSION or SCHEMA_PREV_VERSION

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1056464 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] fix(SchemaMigrator): fix incorrect schema version in error message

https://gerrit.wikimedia.org/r/1056464

Change #1056464 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] fix(SchemaMigrator): fix incorrect schema version in error message

https://gerrit.wikimedia.org/r/1056464