Page MenuHomePhabricator
Create Task
Maniphest T370873

Always show parent ref preview as HTML, not text
Closed, ResolvedPublic
Actions

Description

We took a shortcut in some places in VE, and we show the parent ref as plain text. This is never correct, and obscures some semantic information for example when a {{Cite book}} title is rendered as italics. Always show the HTML instead.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Parent is shown as HTML in the subref create dialogmediawiki/extensions/Citoidmaster+7 -6
Parent is shown as HTML in the subref edit dialogmediawiki/extensions/Citemaster+6 -5
Customize query in gerrit

Event Timeline

awight created this task.Jul 24 2024, 1:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2024, 1:14 PM
gerritbot added a comment.Jul 24 2024, 2:07 PM

Change #1056511 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Parent is shown as HTML in the subref edit dialog

https://gerrit.wikimedia.org/r/1056511

gerritbot added a project: Patch-For-Review.Jul 24 2024, 2:07 PM
awight added a project: WMDE-TechWish-Sprint-2024-07-24.Jul 24 2024, 2:10 PM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-07-24 board.
awight moved this task from Incoming to In progress on the WMDE-References-FocusArea board.
gerritbot added a comment.Jul 24 2024, 4:14 PM

Change #1056511 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parent is shown as HTML in the subref edit dialog

https://gerrit.wikimedia.org/r/1056511

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 4:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 24 2024, 5:00 PM
awight moved this task from In progress to Done on the WMDE-References-FocusArea board.Jul 29 2024, 10:12 AM
gerritbot added a comment.Aug 1 2024, 10:45 AM

Change #1059033 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Citoid@master] Parent is shown as HTML in the subref create dialog

https://gerrit.wikimedia.org/r/1059033

gerritbot added a project: Patch-For-Review.Aug 1 2024, 10:45 AM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2024-07-24 board.Aug 1 2024, 12:00 PM
gerritbot added a comment.Aug 1 2024, 12:03 PM

Change #1059033 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Parent is shown as HTML in the subref create dialog

https://gerrit.wikimedia.org/r/1059033

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2024, 12:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Aug 1 2024, 1:00 PM
thiemowmde closed this task as Resolved.Aug 13 2024, 9:13 AM
thiemowmde claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits