Page MenuHomePhabricator

Unify interactive states across Codex components phase 2
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

Across components which are interactive, the states of said components utilize different patterns for their interactive states. Some components start blue and stay blue through their interactive states, some start blue and gray, and become completely blue, while others remain gray throughout their entire interactivity. Additionally, some use a border only, or background only, or a mix of both throughout the states of interactivity to denote a new state with the previously mentioned, various combinations of colors.

This is a continuation of T377977: Update interactive styles of components: phase 1 for elements which have not yet been resolved.

Goal

Updates to be made:

  • Menu to use progressive and progressive-subtle-- tokens for all content and interactive state backgrounds for selected and destructive and destructive-subtle-- tokens for all content and interactive state backgrounds which are destructive
  • Tabs framed interactive states to use mix-blend-mode interactive tokens and match bottom border [box-shadow] to text color in all modes
  • ToggleButton toggled-on state should follow same styles/interactive styles as the primary progressive button
  • Update interactive states for Accordion to match similar components

Acceptance criteria

  • Identify any remaining inconsistencies between interactive states across components.
  • Update any necessary interactive states
    • Figma
    • Code
Expected changes

wikimedia-ui.json

Token namenew, update, or remove?beforeafteradditional notes
blend-mode.100new-normaladded for use in framed selected tabs

application.json

Token namenew, update, or remove?beforeafteradditional notes
mix-blend-mode-basenew-blend-mode.100
box-shadow-color-progressive-selected--hoverupdatedblue600blue800updated for use in Tabs interactive states
background-color-interactive--hovernew-gray200added for use in quiet toggledOn ToggleButton interactive states
background-color-interactive--activenew-gray300added for use in quiet toggledOn ToggleButton interactive states

dark.json

Token namenew, update, or remove?beforeafteradditional notes
box-shadow-color-progressive-selectednew-blue400updated for use in Tabs interactive states
box-shadow-color-progressive-selected--hovernew-blue300updated for use in Tabs interactive states
box-shadow-color-progressive-selected--activenew-blue200updated for use in Tabs interactive states
background-color-interactive--hovernew-gray700added for use in quiet toggledOn ToggleButton interactive states
background-color-interactive--activenew-gray600added for use in quiet toggledOn ToggleButton interactive states

Event Timeline

CCiufo-WMF renamed this task from Unify states in some components to Unify interactive states across components.Oct 1 2024, 11:42 PM
CCiufo-WMF renamed this task from Unify interactive states across components to Unify interactive states across Codex components.
CCiufo-WMF renamed this task from Unify interactive states across Codex components to Explore unifying interactive states across Codex components.Oct 3 2024, 3:33 PM
DTorsani-WMF renamed this task from Explore unifying interactive states across Codex components to Unify interactive states across Codex components phase 2.Nov 25 2024, 6:45 PM
DTorsani-WMF updated the task description. (Show Details)

Change #1098591 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add new tokens and update styles of buttons

https://gerrit.wikimedia.org/r/1098591

Change #1098624 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add new tokens to support changes also made to unify interactive styles phase 2

https://gerrit.wikimedia.org/r/1098624

Change #1098624 merged by jenkins-bot:

[design/codex@main] tokens: Add new tokens to support changes also made to unify interactive styles phase 2

https://gerrit.wikimedia.org/r/1098624

Change #1101943 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.17.0 to v1.18.0

https://gerrit.wikimedia.org/r/1101943

Change #1101943 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.17.0 to v1.18.0

https://gerrit.wikimedia.org/r/1101943