Page MenuHomePhabricator

Community Wishlist bot adds wishes to aggregate groups multiple times
Closed, ResolvedPublic2 Estimated Story Points

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal subscribed.

Adding a page to an aggregate group is supposed to be idempotent, so this sounds like a bug in MediaWiki-extensions-Translate. There should not be a log entry for a change that didn't actually happen. I think we should try to fix that, but if it turns out to be too much hassle, we of course can have the bot check if the wish is already marked for translation before adding it to the aggregate group.

I think this is specifically about logging. The code removes duplicate sub groups before saving it in the database.

Change #1057232 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] AggregateGroups: Add log entry only if group is added or removed

https://gerrit.wikimedia.org/r/1057232

abi_ triaged this task as Medium priority.
abi_ set the point value for this task to 2.

I think this is specifically about logging. The code removes duplicate sub groups before saving it in the database.

I've submitted a patch to fix this. Will try to have it roll out with the next train.

Change #1057232 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AggregateGroups: Add log entry only if group is added or removed

https://gerrit.wikimedia.org/r/1057232

I think this is specifically about logging. The code removes duplicate sub groups before saving it in the database.

I've submitted a patch to fix this. Will try to have it roll out with the next train.

It didn't catch the train this week, will roll out next week.

Deployed and tested on translatewiki.net. Waiting for confirmation that this works as expected for the Community wishlist before resolving.

Marking this as done as per testing on translatewiki.net. Please re-open if this is still an issue.