Community Tech bot added the wish to an aggregate group three times. This doesn't cause any major harm, but is unnecessary and clutters the log.
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| AggregateGroups: Add log entry only if group is added or removed | mediawiki/extensions/Translate | master | +25 -15 |
Related Objects
Event Timeline
Adding a page to an aggregate group is supposed to be idempotent, so this sounds like a bug in MediaWiki-extensions-Translate. There should not be a log entry for a change that didn't actually happen. I think we should try to fix that, but if it turns out to be too much hassle, we of course can have the bot check if the wish is already marked for translation before adding it to the aggregate group.
I think this is specifically about logging. The code removes duplicate sub groups before saving it in the database.
Change #1057232 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):
[mediawiki/extensions/Translate@master] AggregateGroups: Add log entry only if group is added or removed
I've submitted a patch to fix this. Will try to have it roll out with the next train.
Change #1057232 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] AggregateGroups: Add log entry only if group is added or removed
Deployed and tested on translatewiki.net. Waiting for confirmation that this works as expected for the Community wishlist before resolving.
Marking this as done as per testing on translatewiki.net. Please re-open if this is still an issue.