Page MenuHomePhabricator
Create Task
Maniphest T370940

Maintenance_bot removing patch-for-review cause archived projects to be removed from task
Closed, InvalidPublic
Actions

Description

@Maintenance_bot went to remove the infamous Patch-For-Review tag on the old task T137973#9999757 and upon receiving the notification I noticed it already removed some old deployment tags:

archived_projects_vanishing.png (90×946 px, 27 KB)

I have asked the bot operator (Amir) who states about the bot:

It removes patch for review. I assume somehow phabricator removes others too. I haven't made any specific change on how it works

So my guess is Phabricator is being smart and automagically remove archived project. I don't know if it always did that, but that is the first time I notice so maybe that is a change from a recent upgrade. Overall, I think archived projects should be left untouched but I am archeologist freak.

Related Objects

Event Timeline

hashar created this task.Jul 24 2024, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2024, 6:08 PM
hashar updated the task description. (Show Details)Jul 24 2024, 6:12 PM
matmarex subscribed.Jul 24 2024, 6:41 PM

They were probably removed not because they're archived, but because https://phabricator.wikimedia.org/tag/wmf-deploy-2016-06-28_1.28.0-wmf.8/ https://phabricator.wikimedia.org/tag/wmf-deploy-2016-07-05_1.28.0-wmf.9/ and https://phabricator.wikimedia.org/tag/wmf-deploy-2016-07-12_1.28.0-wmf.10/ are all milestones of the same project https://phabricator.wikimedia.org/project/board/1982/?hidden=true.

It should not be possible to apply more than 1 of these tags on a single task, although I've seen it happen before (I don't have an example to share though). Maybe current versions of Phorge try harder to prevent or "fix" issues like that.

Aklapper closed this task as Invalid.EditedJul 24 2024, 11:30 PM

Phabricator does not remove archived projects (as that would destroy valid information). The screenshot shows that "Maintenance bot removed projects". However, a task can only be in 1 subprojectmilestone of a shared parent project, so I can imagine that Phabricator enforced this rule here (as archived MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)) was not removed). I do not know why it was not enforced earlier - maybe a bug in older code.

Pppery subscribed.Jul 25 2024, 12:48 AM

My guess is that they were at one point standalone projects, and then somebody ran a command-line script to make them subprojects.

hashar added a subscriber: ReleaseTaggerBot.Jul 25 2024, 7:03 AM

The @ReleaseTaggerBot added two projects and maybe they were not milestones at the time or the uniqueness was not enforced

release_tagger_multiple_milestones.png (79×824 px, 24 KB)

Anyway the removed tags being milestones explains why Phabricator removed them. Thank you for having solved the mystery!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits