Page MenuHomePhabricator

[S] Fix poor transition on iPadOS 18
Closed, ResolvedPublic

Description

After we merged https://github.com/wikimedia/wikipedia-ios/pull/4876, it seems most of our navigation transitions now look clunky only on builds from Xcode 16 beta. This task is to dig into those problems and fix them.

test2.gif (355×540 px, 2 MB)

Engineering Notes

TS Note: I have done some light investigation into this one. My discoveries are that custom navigation transitions and hidesBottomBarWhenPushed = true or YES cause these issues.

One quick fix thing we could try is:

  1. Return nil here if user is on iPadOS18.
  2. Add a conditional around any time we set hidesBottomBarWhenPushed = true or hidesBottomBarWhenPushed = YES to only execute if user is not on iPadOS18.

This bypasses the bug while making some design concessions (we lose some nice custom transitions and the floating tab bar is always displayed). I think these tradeoffs are acceptable because we plan on reworking our navigation later this year.

QA Notes

On iPadOS18, confirm navigation transitions look okay.

Event Timeline

Tsevener moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App board.
Tsevener renamed this task from Fix poor transition on iPadOS 18 to [S] Fix poor transition on iPadOS 18.Aug 27 2024, 7:34 PM
Tsevener updated the task description. (Show Details)
Tsevener added a subscriber: GOlson-WMF.