"Add interlanguage links" does not work for temporary accounts
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jul 25 2024, 8:22 AM

Project Tags

Referenced Files

	F56705324: image.png
	Jul 26 2024, 2:10 PM

	F56670093: add_interlanguage_links.png
	Jul 25 2024, 8:22 AM

Subscribers

Lucas_Werkmeister_WMDE

Lydia_Pintscher

Description

What is the problem?

When clicking "Add interlanguage links" as a temporary user, nothing appears to happen. In the top left of the screen I see a cut off "Error..." popup.

Steps to reproduce problem

https://test.wikipedia.org/wiki/1941_in_Scotland
If you don't have a temporary account, check you are logged out and make an edit to create one
Click "Add interlanguage links" in the Tools menu

Expected behaviour: The "Link with page" popup appears or you are redirected to https://test.wikidata.org/wiki/Special:NewItem?site=testwiki&page=1941+in+Scotland.
Observed behaviour: Nothing happens. You see "Error..." in the top right.

Environment

Browser: Firefox 115, Chromium 120.
Wiki(s): https://test.wikipedia.org MediaWiki 1.43.0-wmf.15 (b30ac00) 22:23, 22 July 2024. WikibaseClient – (a3a74fd) 07:26, 22 July 2024.

Screenshots

add_interlanguage_links.png (1,666×635 px, 139 KB)

Acceptance Criteria

The "Add interlanguage links" should appear as a regular link without any interactive user interface

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Only show interwiki links dialog for named users	Arthur taylor	mediawiki/extensions/Wikibase	master	+29 -11

Customize query in gerrit

Related Objects

Mentioned Here: T351971: Check if client LinkItem widget leaks IP on the repo of the edited Item
rEWBAa3a74fdcdbd1: Localisation updates from https://translatewiki.net.
rMWb30ac0000dc1: Updates for Arabic (ar) and Egyptian Arabic (arz)

Event Timeline

dom_walden created this task.Jul 25 2024, 8:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2024, 8:22 AM

Maintenance_bot added a project: Wikidata.Jul 25 2024, 8:30 AM

Thank you!

It seems we missed something in the previous work in T351971#9516414.
Conceptually I think we had decided that the link should not be shown for temporary accounts.

I think the unhelpful error message might be because the API response for the meta=userinfo API request to Wikidata is missing CORS headers?

In T370991#10017934, @Lydia_Pintscher wrote:

Conceptually I think we had decided that the link should not be shown for temporary accounts.

Or rather, I think, that it should just be a regular link without any interactive user interface – at least that’s what currently happens for anonymous visitors.

👍

Arian_Bozorg updated the task description. (Show Details)Jul 30 2024, 9:16 AM

• karapayneWMDE moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Jul 30 2024, 11:48 AM

Arian_Bozorg moved this task from SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) to Incoming on the [Archived]Wikidata Dev Team board.Jul 30 2024, 11:48 AM

Arian_Bozorg moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.

ArthurTaylor claimed this task.Aug 8 2024, 11:12 AM

ArthurTaylor edited projects, added: [Archived]Wikidata Dev Team (Wikidata.org Slice); removed: [Archived]Wikidata Dev Team.

ArthurTaylor moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Change #1061057 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Only show interwiki links dialog for named users

https://gerrit.wikimedia.org/r/1061057

gerritbot added a project: Patch-For-Review.Aug 9 2024, 11:05 AM

ArthurTaylor removed ArthurTaylor as the assignee of this task.Aug 9 2024, 11:09 AM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

ArthurTaylor subscribed.

Change #1061057 merged by jenkins-bot: