Page MenuHomePhabricator

Roll out appearance menu and font size change to sister projects
Closed, ResolvedPublic1 Estimated Story Points

Description

NOTE: deployment tentative date, September 9

Background

  • We believe we are now ready to proceed with delivering the appearance menu across wikis, including sister projects

User story

  • As a user of a non-Wikipedia Wikimedia wiki, I would like the ability to change my font size so that I can read with ease

Requirements

  • Deploy appearance menu for Vector 22 users to all wikis for logged in users on 9th September
  • Check wikis for any breakages relating to gadgets and help them fix them.
  • Deploy appearance menu for Vector 22 users to all wikis for anonymous users on 11th September.
  • Switch font size default for these wikis to regular for logged out users only

Requirement

Roll out the appearance menu, including font size adjustments, to all Wikimedia wikis using the Vector 2022 skin. The menu will be deployed first to logged-in users on September 9th and then to anonymous users on September 11th. The default font size for logged-out users should be set to regular. Dark mode should be unavailable to anonymous users, while logged-in users can enable it via the beta feature.

BDD

Feature: Roll out appearance menu and font size change to sister projects

  Scenario: Appearance menu available for logged-in users on all wikis
    Given the user is logged in
    When they visit any Wikimedia wiki using the Vector 2022 skin
    Then the appearance menu should be available with font size adjustments

  Scenario: Appearance menu available for anonymous users on all wikis
    Given the user is logged out
    When they visit any Wikimedia wiki using the Vector 2022 skin
    Then the appearance menu should be available with font size adjustments

  Scenario: Dark mode restricted for anonymous users
    Given the user is logged out
    When they visit any Wikimedia wiki using the Vector 2022 skin
    Then dark mode should not be available

  Scenario: Dark mode available for logged-in users via beta
    Given the user is logged in
    When they enable the beta feature
    Then dark mode should be available

Test Steps

Test Case 1: Verify Appearance Menu for Logged-In Users

  1. Log in to a Wikimedia sister project using the Vector 2022 skin (e.g., pl.wikisource.org).
  2. AC1: Confirm that the appearance menu is available and includes font size adjustments.

Test Case 2: Verify Appearance Menu for Anonymous Users

  1. Log out and visit the same sister project using the Vector 2022 skin.
  2. AC2: Confirm that the appearance menu is available and includes font size adjustments.

Test Case 3: Verify Dark Mode is Unavailable to Anonymous Users

  1. As an anonymous user, check the appearance menu.
  2. AC3: Confirm that dark mode is not available.

Test Case 4: Verify Dark Mode is Available for Logged-In Users via Beta

  1. Log in and enable the beta feature on the sister project.
  2. AC4: Confirm that dark mode becomes available in the appearance menu.

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Must be communicated to these wikis prior to deployment - check with @sgrabarczuk

prior to deploy

Rollback plan

If we have any issues, first we will attempt to resolve them locally via adjustments to gadgets.
For anything urgent/serious, if unavoidable we can revert the changes in T367591: Remove old limited width toggle and backport that change along with site-specific config patch but we should do this as a last resort!

This task was created by Version 1.2.0 of the Web team task template using phabulous

QA Results - Prod

Event Timeline

ovasileva set the point value for this task to 1.Jul 25 2024, 6:01 PM

Cleanup and other follow-up work will be done in a separate ticket.

Jdlrobson subscribed.

Szymon says we dont want to do this until post Wikimania. Perhaps this shpuld therefore be in sprint 4?

Change #1059393 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Roll out appearance menu and font size change to sister projects

https://gerrit.wikimedia.org/r/1059393

@SToyofuku-WMF, @Jdlrobson - just to confirm this is currently in sprint 4 and we do not plan on rolling out until after Wikimania.

Discussed with @sgrabarczuk. We scheduled:
Announcement to be translated: this week
Announcement goes out: Monday, September 2
Deploy: Monday, September 9

(Prepping deployment patches for next Monday)

Change #1070354 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable appearance menu for all logged in users on all projects

https://gerrit.wikimedia.org/r/1070354

@ovasileva I had a think about this patch and I think we can de-risk it by rolling out to logged in users first. The biggest risk here is gadgets on the wiki not being compatible with the new menu or font size so finding out those issues as early as possible is important to make this go smoothly.

With that in mind could we enable the appearance menu for all logged in users, ideally tomorrow (this would not change the default font size for any user).

Change #1070354 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable appearance menu for all logged in users on all projects

https://gerrit.wikimedia.org/r/1070354

Mentioned in SAL (#wikimedia-operations) [2024-09-09T22:48:02Z] <toyofuku@deploy1003> Started scap sync-world: Backport for [[gerrit:1070354|Enable appearance menu for all logged in users on all projects (T371020)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-09T22:50:01Z] <toyofuku@deploy1003> toyofuku, jdlrobson: Backport for [[gerrit:1070354|Enable appearance menu for all logged in users on all projects (T371020)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-09T23:00:43Z] <toyofuku@deploy1003> Finished scap sync-world: Backport for [[gerrit:1070354|Enable appearance menu for all logged in users on all projects (T371020)]] (duration: 12m 40s)

Updated requirements checklist, and moving to blocked. If all goes to plan this will be rolled out to anonymous users via the train (but I'll likely deploy one day earlier to mitigate risk here).

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Wikis are quiet so we can proceed with next stage.
@KSarabia-WMF will deploy https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1059393?usp=search tomorrow (Wednesday Sept 11). To verify it should be enough to check that the appearance menu shows for anonymous users on https://pl.wikisource.org/ - please also confirm the following

  1. Dark mode is not available to anons
  2. For logged in users, dark mode can be added via beta.

Thanks Kim!

Change #1059393 merged by jenkins-bot:

[operations/mediawiki-config@master] Roll out appearance menu and font size change to sister projects

https://gerrit.wikimedia.org/r/1059393

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:10:10Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1059393|Roll out appearance menu and font size change to sister projects (T371020)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:13:46Z] <cjming@deploy1003> jdlrobson, cjming: Backport for [[gerrit:1059393|Roll out appearance menu and font size change to sister projects (T371020)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-11T20:23:19Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1059393|Roll out appearance menu and font size change to sister projects (T371020)]] (duration: 13m 09s)

Test Result - Prod

Status: ❌ FAIL ✅ PASS
Environment: various
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Appearance Menu for Logged-In Users

  1. Log in to a Wikimedia sister project using the Vector 2022 skin (e.g., pl.wikisource.org).
  2. AC1: Confirm that the appearance menu is available and includes font size adjustments.

screenshot 15.png (1×1 px, 472 KB)

screenshot 14.png (1×1 px, 517 KB)

Test Case 2: Verify Appearance Menu for Anonymous Users

  1. Log out and visit the same sister project using the Vector 2022 skin.
  2. AC2: Confirm that the appearance menu is available and includes font size adjustments.

screenshot 6.png (889×1 px, 544 KB)

screenshot 7.png (889×1 px, 551 KB)

Test Case 3: Verify Dark Mode is Unavailable to Anonymous Users

  1. As an anonymous user, check the appearance menu.
  2. AC3: Confirm that dark mode is not available.

screenshot 9.png (889×1 px, 258 KB)

screenshot 8.png (889×1 px, 258 KB)

Test Case 4: Verify Dark Mode is Available for Logged-In Users via Beta

  1. Log in and enable the beta feature on the sister project.
  2. AC4: Confirm that dark mode becomes available in the appearance menu.

screenshot 13.png (1×1 px, 369 KB)

screenshot 11.png (1×1 px, 383 KB)

screenshot 10.png (1×1 px, 363 KB)

screenshot 12.png (1×1 px, 388 KB)

@Jdlrobson, I noticed some odd behavior and had to go back and test it. When you first go to a new sister project, even if you're globally logged in, it doesn't enable the dark mode option. I'm not sure what triggers it, but when I would check references to see if it was enabled and go back to the same article and reload without making any changes to the preferences, the dark mode option appears in the appearance menu.
Unable to reproduce per T371020#10144966 and T371020#10145364

screenshot 4.mov.gif (910×1 px, 2 MB)

Edtadros subscribed.

@Edtadros is it possible you have it enabled via GlobalPreferences. Could you create a new account to verify this behaviour? If you have a new account you should NOT be seeing dark mode on any of these sister projects for logged in or anonymous users.

@Jdlrobson, I think it does have to do with GlobalPrefs, but I am not able to find any pattern to reproduce it. I'll move this to signoff as passed.

Jdlrobson updated the task description. (Show Details)