Create temporary user on undo/restore in Wikibase
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jul 25 2024, 2:45 PM

Description

Steps to reproduce:

Be on a Wikibase repo wiki with IP Masking enabled
Be logged out (e.g. in a private window)
Go to the history page of an Entity (e.g. an Item)
Try to undo or restore a revision
Try to save page

Shorter reproduction steps:

Open a private window
Load https://wikidata.beta.wmflabs.org/w/index.php?title=Q540739&action=edit&undoafter=1285480&undo=1358435
Click “publish changes”

Currently, this crashes with a CannotCreateActorException because we didn’t implement temp account support in SubmitEntityAction yet:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Support temporary users in SubmitEntityAction	mediawiki/extensions/Wikibase	master	+157 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 [Epic] Update features for temporary accounts
Open	None	T326908 Update WMDE Engineering-owned products that may be affected by IP Masking
Resolved	Arian_Bozorg	T351968 Update Wikidata-related extensions for IP Masking
Resolved	Arian_Bozorg	T355076 Adjust Wikibase repo to not leak IPs when editing and IP masking is enabled
Resolved	Arian_Bozorg	T371030 Create temporary user on undo/restore in Wikibase

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 25 2024, 2:45 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 30 2024, 9:10 AM

karapayneWMDE moved this task from Incoming to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Jul 30 2024, 11:48 AM

ArthurTaylor claimed this task.Aug 8 2024, 9:03 AM

ArthurTaylor edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

ArthurTaylor moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

In my local testing, I can reproduce the issue with EntitySchema, undo/restore and temp accounts. But it seems like with @Lucas_Werkmeister_WMDE's changes in T356148, this works fine. Is that also what you would expect / experience, Lucas?

ArthurTaylor removed ArthurTaylor as the assignee of this task.Aug 8 2024, 11:10 AM

ArthurTaylor moved this task from In Development to Ready for Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

ArthurTaylor subscribed.

Are you sure you tested Wikibase undo/restore? It shouldn’t be affected by any EntitySchema changes. (I just noticed it while working on those because I was looking for other WatchlistManager callers, IIRC.)