Page MenuHomePhabricator

site_generators_tests.TestPagePreloading fails on beta-wiki due to UnknownSiteError (fr)
Closed, ResolvedPublic

Description

======================================================================
ERROR: test_preload_langlinks_count (tests.site_generators_tests.TestPagePreloading)
Test preloading continuation works.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/unittest/mock.py", line 1256, in patched
    return func(*args, **keywargs)
  File "/home/runner/work/pywikibot/pywikibot/tests/site_generators_tests.py", line 2250, in test_preload_langlinks_count
    langlinks=True, quiet=False))
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_generators.py", line 230, in preloadpages
    api.update_page(page, pagedata, rvgen.props)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 998, in update_page
    updater(page, pagedict[element])
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 942, in _update_langlinks
    for link in langlinks}
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 942, in <setcomp>
    for link in langlinks}
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/page/_links.py", line 608, in langlinkUnsafe
    link._site = pywikibot.Site(lang, source.family.name)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/__init__.py", line 243, in Site
    _sites[key] = interface(code=code, fam=fam, user=user)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_apisite.py", line 132, in __init__
    super().__init__(code, fam, user)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_basesite.py", line 91, in __init__
    raise UnknownSiteError(error_msg)
pywikibot.exceptions.UnknownSiteError: Language 'fr' does not exist in family wpbeta

======================================================================
ERROR: test_preload_langlinks_normal (tests.site_generators_tests.TestPagePreloading)
Test preloading langlinks works.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pywikibot/pywikibot/tests/site_generators_tests.py", line 2229, in test_preload_langlinks_normal
    for count, page in enumerate(gen):
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_generators.py", line 230, in preloadpages
    api.update_page(page, pagedata, rvgen.props)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 998, in update_page
    updater(page, pagedict[element])
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 942, in _update_langlinks
    for link in langlinks}
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/data/api/_generators.py", line 942, in <setcomp>
    for link in langlinks}
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/page/_links.py", line 608, in langlinkUnsafe
    link._site = pywikibot.Site(lang, source.family.name)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/__init__.py", line 243, in Site
    _sites[key] = interface(code=code, fam=fam, user=user)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_apisite.py", line 132, in __init__
    super().__init__(code, fam, user)
  File "/home/runner/work/pywikibot/pywikibot/pywikibot/site/_basesite.py", line 91, in __init__
    raise UnknownSiteError(error_msg)
pywikibot.exceptions.UnknownSiteError: Language 'fr' does not exist in family wpbeta

----------------------------------------------------------------------

Event Timeline

Xqt triaged this task as High priority.Jul 26 2024, 3:33 PM
Xqt moved this task from Backlog to Test failures on the Pywikibot-tests board.

Change #1057340 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [fix] Only add lang links to page._langlinks if present in family file

https://gerrit.wikimedia.org/r/1057340

Xqt changed the task status from Open to In Progress.Jul 27 2024, 12:08 PM
Xqt claimed this task.

Change #1057340 merged by jenkins-bot:

[pywikibot/core@master] [fix] Only add lang links to page._langlinks if present in family file

https://gerrit.wikimedia.org/r/1057340