Page MenuHomePhabricator
Create Task
Maniphest T371142

Add a new "fostered-transparent" lint category for when all the fostered content in rendering transparent
Closed, ResolvedPublic
Actions

Description

In T290936, DiscussionTools needed to know about any fostering on a page to avoid corruption.

Several iterations of patches tried to expose lints of fostered rendering transparent tags in a way that wouldn't be too disruptive of editors work (only lint when not template generated and outside the template namespace),
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/721355
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1052192

but it ultimately proved too disruptive and was reverted,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1054407

A new approach (T369317#9983813) would be to introduce a new hidden lint category, "fostered-transparent", that reports these lints separately from "fostered".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a17mediawiki/vendormaster+387 -263
Emit fostered rendering transparent lints as a separate categorymediawiki/services/parsoidmaster+57 -39
Add a "fostered-transparent" lint categorymediawiki/extensions/Lintermaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

ABreault-WMF created this task.Jul 26 2024, 7:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2024, 7:16 PM
ABreault-WMF mentioned this in T369317: False positive Linter "fostered content" errors apparently caused by noinclude tags.Jul 26 2024, 7:17 PM
gerritbot added a comment.Jul 26 2024, 8:41 PM

Change #1057265 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Linter@master] Add a "fostered-transparent" lint category

https://gerrit.wikimedia.org/r/1057265

gerritbot added a project: Patch-For-Review.Jul 26 2024, 8:41 PM
ABreault-WMF triaged this task as Medium priority.Jul 26 2024, 8:41 PM
ABreault-WMF added projects: Essential-Work, Content-Transform-Team-WIP.
ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Jul 26 2024, 8:45 PM
gerritbot added a comment.Jul 26 2024, 8:49 PM

Change #1054409 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Emit fostered rendering transparent lints as a separate category

https://gerrit.wikimedia.org/r/1054409

gerritbot added a comment.Jul 27 2024, 12:36 AM

Change #1057265 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Add a "fostered-transparent" lint category

https://gerrit.wikimedia.org/r/1057265

ABreault-WMF added a comment.Jul 29 2024, 9:47 PM

Before turning this on, it's worth asking, is it ok to be creating these lints if we never really intend for them to go away?

SLopes-WMF removed a project: Parsoid.Aug 8 2024, 2:20 PM
gerritbot added a comment.Aug 16 2024, 7:53 PM

Change #1054409 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Emit fostered rendering transparent lints as a separate category

https://gerrit.wikimedia.org/r/1054409

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Aug 16 2024, 8:06 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 8:31 PM
gerritbot added a comment.Aug 19 2024, 1:53 PM

Change #1063811 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

gerritbot added a project: Patch-For-Review.Aug 19 2024, 1:53 PM
gerritbot added a comment.Aug 19 2024, 2:32 PM

Change #1063811 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

MSantos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Aug 19 2024, 3:09 PM
ssastry closed this task as Resolved.Aug 22 2024, 8:46 PM
ssastry subscribed.

https://en.wikipedia.org/wiki/Special:LintErrors/fostered-transparent now exists.

But, I wonder if there is a different representation we can rely on when we have "<*include*>...</*include*>" style markup in fostered position that (a) eliminates the fostered-content corruption possibilities (b) renders the wikitext back on edits to such tables. That might be worth exploring and might be a better solution. For ex, we could possibly hide all that in a special meta tag before the table OR in some special table attribute. In either case, that should retain enough info to indicate how it should be serialized / where it belongs. Not high priority, but if a lot of discussion tools page edits are thwarted because of this category, a different representation can solve that issue.

Jonesey95 subscribed.Oct 8 2024, 2:23 PM

When you create a new Linter error, even if it is hidden, make sure to add it to https://www.mediawiki.org/wiki/Help:Lint_errors and complete the rest of the "new Linter error" checklist.

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2024, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits