Page MenuHomePhabricator

Special:AbuseFilter doesn't show hits number for public filters to users without abusefilter-log-detail permission
Closed, InvalidPublic

Description

See example (zh.wiki has very strict autoconfirmed requirements so you'll probably not have the permission).
This doesn't make any sense as the hits number is shown in the details page of each filter, you just can't filter the log for the relevant entries.


Version: unspecified
Severity: minor
URL: https://zh.wikipedia.org/wiki/Special:Abusefilter
See Also:
T35380: Details of actions caught by a private filter should be private

Details

Reference
bz35124

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:12 AM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz35124.
bzimport added a subscriber: Unknown Object (MLST).
Daimona subscribed.

Well, the hit count is really only displayed to those with log-detail right (see code). However, that information isn't available in filters' pages. For instance, if I open the page of a public filter I can't see the hit count, which again requires the log-detail number. This means that at the moment we don't have any conflict, all we may think to do is change the right needed to display such info.
However, abusefilter-log-detail is exactly made to allow users see the hit count, filter the AbuseLog by filter ID and see the filter ID for each abuselog. If we show the hitcount, there would be some conflict with the other functionalities. So, actually, the only thing needed here is to properly assign the right.