Page MenuHomePhabricator

CentralAuth should not unconditionally link to Meta-Wiki
Closed, ResolvedPublic

Description

	"centralauth-readmore-text": ":''[[m:Special:MyLanguage/Help:Unified login|Read more about '''unified login''']]…''",
	"centralauth-finish-problems": "Are you having trouble, or are you not the owner of these other accounts?\n[[m:Special:MyLanguage/Help:Unified login|How to find help]]…",

These should be defined by WikimediaMessages as they're pointing to a page specific to unified login on Wikimedia wikis. And they definitely shouldn't use an interwiki not in the default interwiki map to do it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Note the message I'm complaining about here long-predates Account-Vanishing. But thanks for reminding me I need to do a separate codesearch for the even more inexcusable use of interwikis that aren't on the default interwiki map - this came to my attention only because it previously used the URL form and not all of the translations were updated.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

@Pppery if we move the m: messages to a Wikimedia specific collection, what would we make the default message. Would we have a link at all?

Ideally someone would write some wiki-agnostic documentation about the general concept of unified login and place it somewhere on MediaWiki.org.

Tgr subscribed.

CentralAuth is a very Wikimedia-centric extension. Some non-Wikimedia wikis use it, and we try to not break them, but support for non-Wikimedia users is more limited compared to other extensions.Hopefully we get to do T359116: Split up CentralAuth into smaller extensions some day soon to properly separate the Wikimedia-specific bits from the generic ones.

Bugreporter subscribed.

Reopen. At least we need a documentation of CentralAuth at MediaWiki.org - see https://www.mediawiki.org/wiki/Project:MediaWiki_documentation_on_Meta-Wiki

Ideally someone would write some wiki-agnostic documentation about the general concept of unified login and place it somewhere on MediaWiki.org.

@Bugreporter: https://www.mediawiki.org/wiki/Extension:CentralAuth exists already. Which other useful documentation are you missing on mw.org?

Ideally every extensions with user-facing feature must have a user help page in Help namespace. CentralAuth has many functionalities, but is ill documented in MediaWiki.org.

@Bugreporter: Could you please be specific what's missing on mw.org?

For example, the guide of managing global groups is written better and more in a steward (instead of sysadmin) perspective in https://meta.wikimedia.org/wiki/Steward_handbook, and it should belong to help namespace of MediaWiki.org. Many other parts of steward handbook are not specific to Wikimedia but also applies to other wiki farms.

In addition Pppery said we should have a user documentation of general concept of global logins.

Idea:

  • We should create a documentation page on MediaWiki asap. For now, it will be an index for all the CA-related documentations on MediaWiki and Meta-wiki.
  • After doing the above, we can point the link to the MediaWiki page.
  • As an ongoing process, we should rewrite our CA documentation to talk about CA as a generic extension. The rewritten documentations can be moved into MediaWiki-wiki.
  • Finally, most documentations will be hosted on MW-wiki. It is totally fine to have some WMF-specific contents staying on Meta. The main documentation on MW-wiki can be rewritten into a full-featured documentation, combining the key points of all other documentations.

Change #1197208 had a related patch set uploaded (by Manvi Kesarwani; author: Manvi Kesarwani):

[mediawiki/extensions/CentralAuth@master] i18n: Avoid hardcoded Meta-Wiki links in CentralAuth messages (T371306)\n\n- centralauth-readmore-text: make default generic with no interwiki\n- centralauth-finish-problems: remove Meta help link; generic text\n\nThis allows WikimediaMessages or site configs to provide the appropriate\nproject-specific links without CentralAuth unconditionally pointing to Meta.

https://gerrit.wikimedia.org/r/1197208

Change #1197208 had a related patch set uploaded (by Pppery; author: Manvi Kesarwani):

[mediawiki/extensions/CentralAuth@master] i18n: Avoid hardcoded Meta-Wiki links in CentralAuth messages

https://gerrit.wikimedia.org/r/1197208

Change #1198518 had a related patch set uploaded (by Manvi Kesarwani; author: Manvi Kesarwani):

[mediawiki/extensions/CentralAuth@master] i18n: Remove unused message and empty readmore text (T371306)

https://gerrit.wikimedia.org/r/1198518

Change #1198518 abandoned by Manvi Kesarwani:

[mediawiki/extensions/CentralAuth@master] i18n: Remove unused message and empty readmore text (T371306)

Reason:

didn't work

https://gerrit.wikimedia.org/r/1198518

Change #1198518 restored by Bartosz Dziewoński:

[mediawiki/extensions/CentralAuth@master] i18n: Remove unused message and empty readmore text (T371306)

https://gerrit.wikimedia.org/r/1198518

Change #1197208 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/CentralAuth@master] i18n: Avoid hardcoded Meta-Wiki links in CentralAuth messages

Reason:

Continued in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1198518

https://gerrit.wikimedia.org/r/1197208

Change #1198518 had a related patch set uploaded (by Bartosz Dziewoński; author: Manvi Kesarwani):

[mediawiki/extensions/CentralAuth@master] i18n: Remove unused message and empty readmore text

https://gerrit.wikimedia.org/r/1198518

Change #1198518 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] i18n: Remove unused message and empty readmore text

https://gerrit.wikimedia.org/r/1198518

matmarex assigned this task to Manvikesarwani09.
matmarex subscribed.

Thanks for working on the patch, @Manvikesarwani09. It was a bit bumpy, but the final version looks good to me :)

As it turns out, one of the messages @Pppery identified is not used at all, and the other is only used on a page that is not normally reachable on Wikimedia wikis (Special:MergeAccount – we don't link to it anywhere since we completed login unification), so I don't think any overrides in WikimediaMessages are necessary. I think this is resolved.

One last note, I agree with @Tgr in T371306#10607445 that CentralAuth is very Wikimedia-specific, and not intended for other wikis to use. We usually wouldn't accept patches that try to make it more generic at the cost of making the code or our setup more complex. In this case the changes don't hurt, but I want to say this so that people don't put effort intro trying to make further changes along these lines.