Page MenuHomePhabricator

Remove Wikidata-based types/functions that were created in Wikifunctions.org
Closed, ResolvedPublic

Description

Description

6 new Wikidata-based types and some related functions and implementations, listed below, were recently created using the Wikifunctions.org UI.
For technical reasons, these types and functions need to be predefined; that is, their definitions have to be loaded from the function-schemata repository, and they need to have ZIDs < 10,000.

The new predefined definitions now exist in a couple of patches, the content of which was based on the wiki-defined versions, so the wiki-defined versions should be removed. Here are the ZIDs of the wiki-defined versions to be removed (including 6 type definitions, 8 converter functions, 2 equality functions, 4 implementations):

  • Delete from wiki
    • Z17800 - Z17812, inclusive
    • Z17885 - Z17891, inclusive
  • Delete from function-schemata
    • Z7138, Z7139, Z7140 should also be removed. These were experimental types created in August, 2023, but never used.

Completion checklist

Event Timeline

Note:

  • We may want predefined types for each Wikibase value types (not to be confused with data types), such as coordinates
  • If Wikidata access needs data to be returned as number, we need a predefined type for number
    • Note Wikidata stores number as string, not as IEEE 754 floating point number
    • Python allow representing such type of number via decimal object, but there are no native support in JavaScript.
  • Personally, I also want natural number and integer be predefined type, and the custom integer type be scrapped and mirgated. BTW we can just store (big) integer as simple string; storing it as a complex object (sign+natural number) seems an unorthodox solution.
Jdforrester-WMF subscribed.

To do as part of the prod creation/deployment work.

Have deleted the listed ones.

Z7138–Z7140 were never created in prod, just need to be dropped from function-schemata.