Page MenuHomePhabricator

Date link in Special:IPContributions (archive mode) behaves differently to date link in Special:DeletedContributions
Closed, ResolvedPublic

Description

Background

Special:IPContributions in archive mode is similar to Special:DeletedContributions, but shows the deleted contributions for temporary accounts given an IP address (or range), rather than the deleted contributions attributed to a particular user or IP address/range.

Both special pages largely format their results the same, although Special:IPContributions shows some extra information, such as the size of the change. (Special:DeletedContributions will be updated to do the same in T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions).

However, the date links in Special:IPContributions do not work the same way as those in Special:DeletedContributions, which was unintentional and is a bug.

Special:DeletedContributions:

  • If the user viewing the page has the undelete right, the date links to Special:Undelete for the page/timestamp
  • Otherwise the date is not a link

Special:IPContributions (archive mode):

  • If the user viewing the page has the deletedtext right or the undelete right, the date links to the revision itself (with the warning box that the page has been deleted)
  • Otherwise the date is not a link

This was unintentionally done, so Special:IPContributions should be updated to behave like Special:DeletedContributions.

Technical notes

The row formatting for Special:DeletedContributions is done in DeletedContribsPager::formatRevisionRow, and the date link is specified here: https://gerrit.wikimedia.org/g/mediawiki/core/+/848b9fa281dc561a3af9668ec64e91725c4c0f67/includes/specials/pagers/DeletedContribsPager.php#369

The equivalent link is built for Special:IPContributions in ContributionsPager::formatRow with no difference between normal and archive modes: https://gerrit.wikimedia.org/g/mediawiki/core/+/848b9fa281dc561a3af9668ec64e91725c4c0f67/includes/pager/ContributionsPager.php#751

What needs doing

ContributionsPager should be updated to do the same as DeletedContribsPager.

Details

Event Timeline

Tchanders renamed this task from Links in Special:IPContributions (archive mode) behave differently to links in Special:DeletedContributions to Date link in Special:IPContributions (archive mode) behaves differently to date link in Special:DeletedContributions.Jul 31 2024, 4:09 PM

Change #1058645 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsPager: Fix date link in archive mode

https://gerrit.wikimedia.org/r/1058645

Change #1058645 merged by jenkins-bot:

[mediawiki/core@master] ContributionsPager: Fix date link in archive mode

https://gerrit.wikimedia.org/r/1058645

Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning, and displaying as expected for Special:IPContributions in archive mode...
The date & time link is now redirecting the user to Special:Undelete for the page/timestamp.