| Catrope | |
| Jul 31 2024, 8:56 PM |
| F56836683: image.png | |
| Jul 31 2024, 8:56 PM |
| F56836656: image.png | |
| Jul 31 2024, 8:56 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
One of the charts renders very strangely
What should have happened instead?:
The second chart should render normally, like it does when it's the only chart on the page:
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): master branch
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Test for unique ID | mediawiki/extensions/Chart | master | +18 -0 | |
| Prefix IDs in the SVG output to avoid ID collisions | mediawiki/extensions/Chart | master | +123 -189 |
This appears to be caused by ID collisions between clip paths in the two SVGs. Both charts contain nodes like <clipPath id="zr0-c0">, <clipPath id="zr0-c1">, etc, and they both use the same numbering scheme. These IDs conflict with each other. We may be able to fix this by isolating the SVGs in their own document somehow, or by prefixing the IDs.
Change #1058716 had a related patch set uploaded (by Catrope; author: Catrope):
[mediawiki/extensions/Chart@master] Prefix IDs in the SVG output to avoid ID collisions
Change #1059163 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/Chart@master] Test for unique ID
Change #1058716 merged by jenkins-bot:
[mediawiki/extensions/Chart@master] Prefix IDs in the SVG output to avoid ID collisions
Change #1059163 merged by jenkins-bot:
[mediawiki/extensions/Chart@master] Test for unique ID