Page MenuHomePhabricator

GlobalBlockListPagerTest::testFormatRow integration test breaking CI
Closed, ResolvedPublic

Description

This is happening repeatedly at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeMirror/+/1048371

MediaWiki\Extension\GlobalBlocking\Test\Integration\Specials\GlobalBlockListPagerTest::testFormatRow with data set "IPv4 range block" ('1.2.3.0/24', array('(july', 'Test reason2'), array('(infiniteblock', 'Test reason1', 'Test reason3', '(globalblocking-list-whitelisted'))

Failed asserting that '<li>(globalblocking-list-item: 03:20, 1 (august) 2024, TestUser 0f442b.485, TestUser 0f442b.485, wikidb-unittest_, 1.2.3.0/24, <a href="/wiki/Special:Contributions/1.2.3.0/24" class="mw-userlink mw-anonuserlink" title="Special:Contributions/1.2.3.0/24"><bdi>1.2.3.0/24</bdi></a>(word-separator)<span class="mw-usertoollinks">(parentheses: <a href="/index.php?title=User_talk:1.2.3.0/24&amp;action=edit&amp;redlink=1" class="new mw-usertoollinks-talk" title="User talk:1.2.3.0/24 (page does not exist)">(talkpagelinktext)</a>)</span>, 03:20, 1 (september) 2024, ,  <span class="comment">(parentheses: Test reason2)</span>, )</li>' contains "(july".

/workspace/src/extensions/GlobalBlocking/tests/phpunit/Integration/Special/GlobalBlockListPagerTest.php:63

Event Timeline

Change #1058729 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/GlobalBlocking@master] Fix test that only works in June or July

https://gerrit.wikimedia.org/r/1058729

Change #1058729 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Fix test that only works in June or July

https://gerrit.wikimedia.org/r/1058729

MusikAnimal assigned this task to tstarling.

Fixed thanks to Tim!

Change #1060101 had a related patch set uploaded (by Zabe; author: Tim Starling):

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.16] Fix test that only works in June or July

https://gerrit.wikimedia.org/r/1060101

Change #1060101 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.16] Fix test that only works in June or July

https://gerrit.wikimedia.org/r/1060101

Mentioned in SAL (#wikimedia-operations) [2024-08-06T13:54:51Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1060085|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]], [[gerrit:1060101|Fix test that only works in June or July (T371577)]], [[gerrit:1060086|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-06T13:56:52Z] <zabe@deploy1003> abi, zabe: Backport for [[gerrit:1060085|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]], [[gerrit:1060101|Fix test that only works in June or July (T371577)]], [[gerrit:1060086|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-06T14:08:13Z] <zabe@deploy1003> Finished scap: Backport for [[gerrit:1060085|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]], [[gerrit:1060101|Fix test that only works in June or July (T371577)]], [[gerrit:1060086|TranslatablePage: Use local cache to reduce calls to the WAN cache (T366455)]] (duration: 13m 22s)