Page MenuHomePhabricator
Create Task
Maniphest T371578

Parameter of timedmedia-subtitle-no-subtitles message not handled
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):
See e.g. File:Paris agreement signed.webm on Commons

What happens?:
In English, the message box says:

There are currently no subtitles in $1 for this video, you can edit this page to add them.

What should have happened instead?:
$1 should have been replaced with the user language (written in the user language), as specified in the qqq text.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add missing message param for timedmedia-subtitle-no-subtitlesmediawiki/extensions/TimedMediaHandlerREL1_43+1 -1
Add missing message param for timedmedia-subtitle-no-subtitlesmediawiki/extensions/TimedMediaHandlerREL1_42+1 -1
Add missing message param for timedmedia-subtitle-no-subtitlesmediawiki/extensions/TimedMediaHandlermaster+1 -1
Customize query in gerrit

Event Timeline

Bdijkstra created this task.Aug 1 2024, 7:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2024, 7:23 AM
Mbch331 subscribed.Aug 1 2024, 12:51 PM
Ennomien subscribed.Aug 5 2024, 10:11 AM
TheDJ added a project: User-TheDJ.Oct 16 2024, 12:57 PM
TheDJ subscribed.
TheDJ moved this task from To sort to In progress on the TimedMediaHandler board.Oct 16 2024, 1:52 PM
gerritbot added a comment.Oct 25 2024, 6:50 PM

Change #1083270 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083270

gerritbot added a project: Patch-For-Review.Oct 25 2024, 6:50 PM
TheDJ moved this task from Inbox to For-review on the User-TheDJ board.Oct 25 2024, 7:23 PM
gerritbot added a comment.Oct 25 2024, 8:55 PM

Change #1083270 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083270

gerritbot added a comment.Oct 25 2024, 8:56 PM

Change #1083279 had a related patch set uploaded (by Umherirrender; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_43] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083279

gerritbot added a comment.Oct 25 2024, 8:56 PM

Change #1083280 had a related patch set uploaded (by Umherirrender; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_42] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083280

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 25 2024, 9:00 PM
gerritbot added a comment.Oct 25 2024, 9:04 PM

Change #1083280 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_42] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083280

gerritbot added a comment.Oct 25 2024, 9:04 PM

Change #1083279 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_43] Add missing message param for timedmedia-subtitle-no-subtitles

https://gerrit.wikimedia.org/r/1083279

Umherirrender closed this task as Resolved.Oct 25 2024, 9:05 PM
Umherirrender assigned this task to TheDJ.
Maintenance_bot removed a project: Patch-For-Review.Oct 25 2024, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits