Maniphest T371601

Test the GlobalBlock class
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Aug 1 2024, 12:35 PM

Project Tags

Referenced Files

None

Subscribers

Description

The GlobalBlock class is currently completely untested. Testing it is important to ensure that changes made for T17273 do not cause regressions.

Acceptance criteria

The GlobalBlock class is completely tested.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Clean-up code in GlobalBlock	mediawiki/extensions/GlobalBlocking	master	+35 -40
	Test GlobalBlock	mediawiki/extensions/GlobalBlocking	master	+203 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
		Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
		Resolved		Niharika	T324492 Temporary accounts - MVP
		Resolved		Madalina	T326816 [Epic] Update features for temporary accounts
		Resolved		Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
		Resolved		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
		Resolved		None	T40648 Wiki Loves Monuments 2012 (tracking)
		Duplicate		None	T42190 Anonymous only global block prevents account creation
		Resolved	Feature	Dreamy_Jazz	T17273 Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation
		Resolved		Dreamy_Jazz	T371685 Update Special:GlobalBlockList to display whether the active global block prevents account creation
		Resolved		Dreamy_Jazz	T371625 Update the GlobalBlockLogFormatter to indicate whether a block disallows account creation
		Resolved		Dreamy_Jazz	T371693 Update Special:GlobalBlock to indicate whether a block should disallow account creation
		Resolved		Dreamy_Jazz	T371718 Update the globalblock API to support specifying if account creation should be blocked
		Resolved		Dreamy_Jazz	T371619 Update the GlobalBlockingManager to write to the gb_create_account column
		Resolved		Dreamy_Jazz	T371721 Update the 'globalblocks' query API to read the value of gb_create_account
		Resolved		Dreamy_Jazz	T371604 Update the GlobalBlockLookup service to read the value of gb_create_account
		Resolved		Dreamy_Jazz	T371601 Test the GlobalBlock class

Event Timeline

Dreamy_Jazz created this task.Aug 1 2024, 12:35 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptAug 1 2024, 12:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1059060 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test GlobalBlock

https://gerrit.wikimedia.org/r/1059060

gerritbot added a project: Patch-For-Review.Aug 1 2024, 12:35 PM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 1 2024, 12:35 PM

Change #1059069 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Clean-up code in GlobalBlock

https://gerrit.wikimedia.org/r/1059069

Dreamy_Jazz added a parent task: T371604: Update the GlobalBlockLookup service to read the value of gb_create_account.Aug 1 2024, 12:59 PM

Dreamy_Jazz removed a parent task: T17273: Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation.

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 1 2024, 2:02 PM

Dreamy_Jazz set the point value for this task to 1.Aug 1 2024, 2:07 PM

Dreamy_Jazz changed the point value for this task from 1 to 2.

Change #1059060 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test GlobalBlock

https://gerrit.wikimedia.org/r/1059060

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 1 2024, 6:00 PM

Change #1059069 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Clean-up code in GlobalBlock

https://gerrit.wikimedia.org/r/1059069

This can be QA'd through T371604.