Update the GlobalBlockingManager to write to the gb_create_account column
Closed, ResolvedPublic
Actions

Description

The GlobalBlockingManager service needs to write to the gb_create_account column and then apply this to the GlobalBlock instances that it returns. This so that the block can be optionally set to apply to account creation.

This is safe to do so now because the column exists on WMF wikis (T371415).

Acceptance criteria

Update GlobalBlockingManager to write to the gb_create_account column

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Write to gb_create_account in GlobalBlockManager	mediawiki/extensions/GlobalBlocking	master	+42 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved		Niharika	T324492 Temporary accounts - MVP
Resolved		Madalina	T326816 [Epic] Update features for temporary accounts
Open		None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved		None	T40648 Wiki Loves Monuments 2012 (tracking)
Duplicate		None	T42190 Anonymous only global block prevents account creation
Resolved	Feature	Dreamy_Jazz	T17273 Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation
Resolved		Dreamy_Jazz	T371685 Update Special:GlobalBlockList to display whether the active global block prevents account creation
Resolved		Dreamy_Jazz	T371625 Update the GlobalBlockLogFormatter to indicate whether a block disallows account creation
Resolved		Dreamy_Jazz	T371693 Update Special:GlobalBlock to indicate whether a block should disallow account creation
Resolved		Dreamy_Jazz	T371718 Update the globalblock API to support specifying if account creation should be blocked
Resolved		Dreamy_Jazz	T371619 Update the GlobalBlockingManager to write to the gb_create_account column
Resolved		Dreamy_Jazz	T371604 Update the GlobalBlockLookup service to read the value of gb_create_account
Resolved		Dreamy_Jazz	T371601 Test the GlobalBlock class
Resolved		Ladsgroup	T371415 Add gb_autoblock_parent_id, gb_autoblock_enabled, and gb_create_account to the globalblocks table
Resolved		Dreamy_Jazz	T371248 Add gb_create_account column to the globalblocks table

Event Timeline

Dreamy_Jazz created this task.Aug 1 2024, 3:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2024, 3:29 PM

Dreamy_Jazz added a subtask: T371604: Update the GlobalBlockLookup service to read the value of gb_create_account.Aug 1 2024, 3:29 PM

Change #1059121 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Write to gb_create_account in GlobalBlockManager

https://gerrit.wikimedia.org/r/1059121

gerritbot added a project: Patch-For-Review.Aug 1 2024, 4:45 PM

Dreamy_Jazz removed a subtask: T371625: Update the GlobalBlockLogFormatter to indicate whether a block disallows account creation.Aug 1 2024, 4:48 PM

Dreamy_Jazz added a parent task: T371625: Update the GlobalBlockLogFormatter to indicate whether a block disallows account creation.

Dreamy_Jazz removed a parent task: T17273: Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation.

Change #1059121 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Write to gb_create_account in GlobalBlockManager

https://gerrit.wikimedia.org/r/1059121

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2024, 10:30 AM

QA will be done through other tickets. Closing.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 2 2024, 11:00 AM

Dreamy_Jazz added a parent task: T371693: Update Special:GlobalBlock to indicate whether a block should disallow account creation.Aug 2 2024, 12:39 PM

Dreamy_Jazz added a parent task: T371718: Update the globalblock API to support specifying if account creation should be blocked.Aug 2 2024, 7:06 PM

Tchanders closed subtask T371604: Update the GlobalBlockLookup service to read the value of gb_create_account as Resolved.Aug 5 2024, 9:29 AM

Update the GlobalBlockingManager to write to the gb_create_account columnClosed, ResolvedPublicActions