Page MenuHomePhabricator

Community updates: update existing homepage module instrumentation to use the module
Closed, ResolvedPublic

Description

The Growth homepage already instrumentation in place for any homepage module that's added. However the homepagemodule schema requires the module enumeration to add community-updates as a value, otherwise there will be validation errors thrown.

Acceptance criteria

  • No validation errors are triggered when instrumenting community-updates actions through homepagemodule schema

Event Timeline

Change #1059286 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] analytics/legacy/homepagemodule: add community updates module

https://gerrit.wikimedia.org/r/1059286

Change #1059287 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Bump homepagemodule schema

https://gerrit.wikimedia.org/r/1059287

Change #1059286 merged by jenkins-bot:

[schemas/event/secondary@master] analytics/legacy/homepagemodule: add community updates module

https://gerrit.wikimedia.org/r/1059286

Change #1059287 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Bump homepagemodule schema

https://gerrit.wikimedia.org/r/1059287

Etonkovidova subscribed.

We don't need to add link-click for clicking on the CommunityUpdate link?
Checked in beta

  • the impression event for CommunityUpdate module is recorded correctly for desktop and mobile
{"event":{"action":"impression","action_data":"","user_id":11836,"user_editcount":3,"user_variant":"control",
"module":"community-updates","is_mobile":false,"mode":"desktop","homepage_pageview_token":"k1n97sgev0tokvh7ot1rijpis6c03cvh"},"schema":"HomepageModule","webHost":"en.wikipedia.beta.wmflabs.org","wiki":"enwiki","$schema":"/analytics/legacy/homepagemodule/1.6.6","client_dt":"2024-08-30T23:10:51.518Z","meta":{"stream":"eventlogging_HomepageModule","domain":"en.wikipedia.beta.wmflabs.org","id":"dd430c35-c7a4-4e04-8be3-de1698fd07a8","dt":"2024-08-30T23:11:03.838Z","request_id":"211686b0-6725-11ef-91a0-e3c33040138b","topic":"eventlogging_HomepageModule","partition":0,"offset":86785},"dt":"2024-08-30T23:11:03.838Z","http":{"request_headers":{"user-agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36"},"client_ip":""}}

{"event":{"action":"impression","action_data":"","user_id":11836,"user_editcount":3,"user_variant":"control","module":"community-updates","is_mobile":true,"mode":"mobile-summary","homepage_pageview_token":"j8155etbmjrggp5sjrpvcbjn1rnof2lj"},"schema":"HomepageModule","webHost":"en.wikipedia.beta.wmflabs.org","wiki":"enwiki","$schema":"/analytics/legacy/homepagemodule/1.6.6","client_dt":"2024-08-30T23:12:38.206Z","meta":{"stream":"eventlogging_HomepageModule","domain":"en.wikipedia.beta.wmflabs.org","id":"609542c0-2f22-40ef-b047-e1319b61f063","dt":"2024-08-30T23:12:43.954Z","request_id":"5cc303f0-6725-11ef-91a0-e3c33040138b","topic":"eventlogging_HomepageModule","partition":0,"offset":86801},"dt":"2024-08-30T23:12:43.954Z","http":{"request_headers":{"user-agent":"Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1"},"client_ip":""}}
  • no validation errors

Change #1070543 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] HomepageModule: document community updates link id

https://gerrit.wikimedia.org/r/1070543

Change #1070555 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Community updates: add missing instrumentation link id

https://gerrit.wikimedia.org/r/1070555

We don't need to add link-click for clicking on the CommunityUpdate link?

Good catch, ty! Amending in follow-up patch 1070555

Change #1070543 merged by jenkins-bot:

[schemas/event/secondary@master] HomepageModule: document community updates link id

https://gerrit.wikimedia.org/r/1070543

Change #1070555 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Community updates: add missing instrumentation link id

https://gerrit.wikimedia.org/r/1070555

Etonkovidova closed this task as Resolved.EditedSep 24 2024, 12:01 AM

Checked - action: "click" is present:

{"action":"click","experiments":{"assigned":{"growth-experiments":"control"},"enrolled":["growth-experiments"]},"action_subtype":"community-updates-cta","action_source":"community-updates","action_context":"duis_aute_irure_dolor_in_reprehenderit_in_volupta","$schema":"/analytics/product_metrics/web/base/1.3.0","mediawiki":{"database":"cswiki","site_content_language":"cs"},"page":{"content_language":"cs"},"agent":{"client_platform":"mediawiki_js","client_platform_family":"desktop_browser"},"performer":{"session_id":"[...]","active_browsing_session_token":"[...]","name":"ET13","is_bot":false,"is_logged_in":true,"edit_count_bucket":"100-999 edits","groups":["sysop","*","user","autoconfirmed"],"registration_dt":"2020-02-25T20:22:55.000Z","is_temp":false,"language":"cs","pageview_id":"18409e498836ee847b45"},"sample":{"unit":"pageview","rate":1},"dt":"2024-09-23T23:54:58.532Z","meta":{"stream":"mediawiki.product_metrics.homepage_module_interaction","domain":"cs.wikipedia.beta.wmflabs.org","id":"9638fe7f-b618-4a8c-8864-c2aa95161c3a","dt":"2024-09-23T23:55:05.404Z","request_id":"[...],"topic":"eqiad.mediawiki.product_metrics.homepage_module_interaction","partition":0,"offset":116},"http":{"request_headers":{"user-agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36"}}}