Page MenuHomePhabricator

Edit button placement is mixed with content
Closed, ResolvedPublicBUG REPORT

Description

This should be a regression due to my changes which I'm fixing right now,

Steps to replicate the issue (include links if applicable):

Create a local English wiki with last revision of MediaWiki, c20692d9f130ac2f8de1d632fc05f0b6b07e020d, and put the following somewhere

<div dir="rtl">
== section ==
content
</div>

<div dir="ltr">
== section ==
content
</div>

<div dir="rtl">
== عنوان ==
content
</div>

<div dir="ltr">
== عنوان ==
content
</div>

What happens?:
Edit button placement is incorrect at top right,

image.png (1,606×686 px, 58 KB)

What should have happened instead?:

image.png (1,612×682 px, 58 KB)

Event Timeline

Change #1059381 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Fix edit button placement in mixed direction content

https://gerrit.wikimedia.org/r/1059381

Ok, no need to panic, this doesn't seems like a regression in MediaWiki, the reason I just saw it is I disabled VisualEditor so I just saw it and the way it work in VisualEditor is this https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/48d5697d0ac115b7253b7713dbb49f7dadd38bda/modules/ve-mw/preinit/styles/ve.init.mw.DesktopArticleTarget.init.less#L149-L152 which clearly belongs to MediaWiki itself than VisualEditor and is what I suggested as a fix for MediaWiki.

Change #1059385 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/VisualEditor@master] Move editsection bidi isolate to MediaWiki

https://gerrit.wikimedia.org/r/1059385

Change #1059381 merged by jenkins-bot:

[mediawiki/core@master] Fix edit button placement in mixed direction content

https://gerrit.wikimedia.org/r/1059381

Ah, I only tested with VisualEditor enabled, thanks for catching this.

Change #1059385 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move editsection bidi isolate to MediaWiki

https://gerrit.wikimedia.org/r/1059385

matmarex assigned this task to Ebrahim.
matmarex removed a project: Patch-For-Review.