Page MenuHomePhabricator

[1.45] Remove wgParserEnableLegacyHeadingDOM option to disable new heading HTML
Closed, ResolvedPublic

Description

The changes implemented in T13555: .mw-editsection links should not be part of the <h#> element (see "Heading HTML changes") can be enabled or disabled using the config setting $wgParserEnableLegacyHeadingDOM.

As documented in the release notes at the time, and on that documentaton page, in a future release after they are enabled by default, we should remove that config setting. This is tentatively planned for MediaWiki 1.45.

Related Objects

Event Timeline

Jdlrobson renamed this task from Remove option to disable new heading HTML to [1.45] Remove option to disable new heading HTML.Dec 11 2024, 4:15 PM
Jdlrobson triaged this task as High priority.
Jdlrobson renamed this task from [1.45] Remove option to disable new heading HTML to [1.45] Remove wgParserEnableLegacyHeadingDOM option to disable new heading HTML.Jan 9 2025, 9:53 PM

Can we aim to do this the first week of 1.45? Supporting this is causing some slow down on fixing some editing bugs and web team migrations to Parsoid?

This is blocking MobileFrontend's preparation for Parsoid. Would appreciate it if we could coordinate over next 3 weeks to get this done!

Change #1143895 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove $wgParserEnableLegacyHeadingDOM and supporting code

https://gerrit.wikimedia.org/r/1143895

Change #1143898 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/LabeledSectionTransclusion@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143898

Change #1143899 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/PageImages@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143899

Change #1143900 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/QuickSurveys@master] Remove mention of $wgParserEnableLegacyHeadingDOM in README

https://gerrit.wikimedia.org/r/1143900

Change #1143901 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Scribunto@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143901

Change #1143902 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143902

Change #1143903 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Example@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143903

Change #1143904 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143904

Change #1143905 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Modern@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143905

Change #1143906 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MonoBook@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143906

Change #1143907 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Nostalgia@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143907

Change #1143908 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Timeless@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143908

Change #1143909 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143909

Thanks for the reminder. You can review the patches whenever you're ready.

Jdlrobson-WMF changed the task status from Open to In Progress.May 12 2025, 5:12 PM
Jdlrobson-WMF lowered the priority of this task from High to Medium.May 12 2025, 5:26 PM

Change #1146034 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_44] Provide more warning about the heading HTML changes in this release

https://gerrit.wikimedia.org/r/1146034

Change #1143895 merged by jenkins-bot:

[mediawiki/core@master] Remove $wgParserEnableLegacyHeadingDOM and supporting code

https://gerrit.wikimedia.org/r/1143895

Change #1143898 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143898

Change #1146034 merged by jenkins-bot:

[mediawiki/core@REL1_44] Provide more warning about the heading HTML changes in this release

https://gerrit.wikimedia.org/r/1146034

Change #1143901 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143901

Change #1143908 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143908

Change #1143906 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143906

Change #1143907 merged by jenkins-bot:

[mediawiki/skins/Nostalgia@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143907

Change #1143905 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143905

Change #1143903 merged by jenkins-bot:

[mediawiki/skins/Example@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143903

Change #1143902 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143902

Change #1143900 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Remove mention of $wgParserEnableLegacyHeadingDOM in README

https://gerrit.wikimedia.org/r/1143900

Change #1143899 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Remove overrides for $wgParserEnableLegacyHeadingDOM in tests

https://gerrit.wikimedia.org/r/1143899

Change #1143909 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143909

Change #1143904 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove support for legacy heading markup

https://gerrit.wikimedia.org/r/1143904

Change #1152165 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Remove wgParserEnableLegacyHeadingDOM option

https://gerrit.wikimedia.org/r/1152165

Change #1152165 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgParserEnableLegacyHeadingDOM option

https://gerrit.wikimedia.org/r/1152165

Mentioned in SAL (#wikimedia-operations) [2025-06-02T20:25:29Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1152165|Remove wgParserEnableLegacyHeadingDOM option (T371756)]]

Mentioned in SAL (#wikimedia-operations) [2025-06-02T20:27:25Z] <arlolra@deploy1003> arlolra: Backport for [[gerrit:1152165|Remove wgParserEnableLegacyHeadingDOM option (T371756)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-06-02T20:36:07Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1152165|Remove wgParserEnableLegacyHeadingDOM option (T371756)]] (duration: 10m 37s)