Change #1062717 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] [WIP] Add preference for viewing protected variables in AbuseFilter

https://gerrit.wikimedia.org/r/1062717

Change #1062718 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] [WIP] Log changes to protected variables access

https://gerrit.wikimedia.org/r/1062718

Change #1072555 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] [WIP] Log specific views of protected variables

https://gerrit.wikimedia.org/r/1072555

Change #1062717 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Add preference for viewing protected variables in AbuseFilter

https://gerrit.wikimedia.org/r/1062717

Change #1062718 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Log changes to protected variables access

https://gerrit.wikimedia.org/r/1062718

Change #1074725 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Add support for AbuseFilter's protected var view log

https://gerrit.wikimedia.org/r/1074725

Change #1074969 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] Bugfix: Fix minor issues with protected vars logging

https://gerrit.wikimedia.org/r/1074969

Change #1074969 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Bugfix: Fix minor issues with protected vars logging

https://gerrit.wikimedia.org/r/1074969

Change #1074725 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Add support for AbuseFilter's protected var view log

https://gerrit.wikimedia.org/r/1074725

Change #1074725 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add support for AbuseFilter's protected var view log

https://gerrit.wikimedia.org/r/1074725

AbuseFilter is far too complicated and untestable for me to have much confidence that I know its current status.

There are too many combinations to test, too many endpoints and AbuseFilter doesn't have an API to make testing them easier.

See also comments made in T151116#10196141.

I have only tested with temporary accounts enabled. I have not tested global filters.

I have focused on permissions testing: are filters/logs which use the user_unnamed_ip variable hidden from users without the right to see them?

The below testing should be treated with caution.

Special:AbuseFilter:

• Cannot see protected filters
• Cannot search for "user_unnamed_ip"
• Tested a few protected filters with Special:AbuseFilter/<filter id> and got "You may not view details of this filter, because it uses protected variables and is hidden from public view."

Special:AbuseLog/<log id>:

• This was reasonably systematically tested via phpunit for different combinations of filters and log events

Special:AbuseFilter/examine/<rc id>:

• The "user_unnamed_ip" variables always appears as "null"

Special:AbuseFilter/examine/log/<log id>:

• Tested a large number of abuse filter logs to check that no IPs appeared

Special:AbuseFilter/test:

• Load filter ID did not load any protected variables (actually uses list=abusefilter)
• Settings "rules to test" as "user_unnamed_ip" and clicking "Test" returned "The filter is not shown, as it uses protected variables and is hidden from public view."
• Testing a few protected filters in Special:AbuseFilter/test/<filter id> returned same error as above

Special:AbuseFilter/history:

• Don't see protected filters in the table
• Cannot search the history for a protected filter ("The filter you requested uses protected variables, and you cannot view its history.")
• Going to Special:AbuseFilter/history/<filter id>/item/<history id> returns "You may not view details of this filter, because it uses protected variables and is hidden from public view."
• Special:AbuseFilter/history/<filter id>/diff/<history id>/<history id> does show if both <history id>'s are not protected, regardless of whether <filter id> is currently protected
  • Otherwise you see "The filter you requested uses protected variables, and you cannot view its history."

Special:AbuseFilter/revert:

• You can revert actions taken by filters which you don't have permission to see

Api action=abusefiltercheckmatch:

• Cannot see a log I don't have permission to see ("info": "Permission denied.")
• When looking up a recent change ID, it always seems to return "result": true regardless of whether the filter is protected, unprotected or does not exist

Api action=abusefilterchecksyntax:

• Always seemed to return "status": "ok" regardless of whether the filter's pattern was valid or not

Not tested (no risk related to recent work identified):

• Special:AbuseLog/private/<log id>
• Special:AbuseFilter/tools
• action=abusefilterevalexpression
• action=abusefilterunblockautopromote
• action=abuselogprivatedetails