Page MenuHomePhabricator

New lines surrounded by triple curly brackets are eliminated by parsoid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

{{{Before you advertise<br/>
all the fame is implied

with no fortune unseen}}}

This testcase is shown at https://en.wikipedia.org/wiki/User:Aaron_Liu/sandbox. Surrounding with nowiki fixes the issue.

What happens?:

In parsoid, this renders to look like:

{{{Before you advertiseall the fame is impliedwith no fortune unseen}}}

(in fact, that is the exact text inside the jumbled <p> element.)

What should have happened instead?:

Before, with the legacy parser, it looks like:

{{{Before you advertise
all the fame is implied

with no fortune unseen}}}

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Wikipedia

Other information (browser name/version, screenshots, etc.):

This is useful for a wiki I'm constructing where lyrics sang in unison are surrounded with {{{}}} while lyrics sung concurrently are surrounded with {}.

image.png (772×555 px, 150 KB)

Event Timeline

Change #1076275 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1076275

Change #1076275 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1076275

Change #1078448 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a24

https://gerrit.wikimedia.org/r/1078448

Change #1078448 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a24

https://gerrit.wikimedia.org/r/1078448

Change #1081272 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@REL1_42] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081272

Change #1081287 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@REL1_41] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081287

Change #1081290 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@REL1_39] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081290

Change #1081272 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_42] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081272

Change #1081290 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081290

thanks! I am honored to have created essential work for y'all /hj

Change #1081287 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_41] Preserve newlines in tpl arg names when not substituted

https://gerrit.wikimedia.org/r/1081287