Page MenuHomePhabricator

Allow tag labels and links to be translateable separately
Closed, ResolvedPublic

Description

Following a discussion on T370954: Link App-specific Tags in Special:Tags to Apps Revision Tags anchors:

Does it have to be in the messages?

The link target is the same in all the languages. It would be far better for the translators if they didn't have to do all this copying and pasting.

Can the link target be added in the code?

I'm afraid it currently has to be in the messages. There is no way to customize the appearance of a tag other than defining a message called tag-<tagname>, and may other extensions do the same thing: https://codesearch.wmcloud.org/search/?q="tag-[\w_-]%2B"%3A+"\[&files=en.json

Maybe it would be good to add a way to do it (e.g. the links could be stored in separate messages like taglink-<tagname>, and would be combined with the tag labels by MediaWiki). I think that's a separate feature request though, and it shouldn't block this change.

I'm bot blocking, I'm just trying to make things easier 🤷🏻‍♂️

Can you please report another task that suggests to improve it? I'm not sure that I completely understand the issue that prevents it.

Event Timeline

Change #1062462 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Allow change tags to have help links in separate messages

https://gerrit.wikimedia.org/r/1062462

I didn't get around to this during the hackathon as I planned, but here it is.

If the change is approved, I'll update the various extensions to use the new messages.

Change #1062462 merged by jenkins-bot:

[mediawiki/core@master] Allow change tags to have help links in separate messages

https://gerrit.wikimedia.org/r/1062462

Change #1077015 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/ContentTranslation@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077015

Change #1077016 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077016

Change #1077020 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Allow wikitext markup in tag help links

https://gerrit.wikimedia.org/r/1077020

Change #1077022 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077022

Change #1077020 merged by jenkins-bot:

[mediawiki/core@master] Allow wikitext markup in tag help links

https://gerrit.wikimedia.org/r/1077020

Change #1077015 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077015

Change #1077016 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077016

Change #1077022 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1077022

Change #1097489 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileApp@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1097489

Change #1097490 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileApp@master] Update and fix tag message translations

https://gerrit.wikimedia.org/r/1097490

Translators/scripts had almost no time to catch up with these changes, causing texts like "[⧼discussiontools-replywidget-reply-link⧽ Reageerfunctie]" to show up on group0 wiki's.

Oops, I should have updated the message translations on Translatewiki after this change, but after waiting 2 months for it to be merged, I just forgot.

I'll deploy a change to temporarily restore the missing message today, and then clean up the translations later.

I see that Raymond covered for me and took care of that for the VisualEditor messages, but not DiscussionTools messages.

Change #1098585 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Temporarily restore renamed messages

https://gerrit.wikimedia.org/r/1098585

Change #1098590 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.44.0-wmf.5] Temporarily restore renamed messages

https://gerrit.wikimedia.org/r/1098590

Change #1098590 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.44.0-wmf.5] Temporarily restore renamed messages

https://gerrit.wikimedia.org/r/1098590

Change #1098585 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@master] Temporarily restore renamed messages

Reason:

Backported to wmf.5, shouldn't be needed on master (translations were already updated on translatewiki.net)

https://gerrit.wikimedia.org/r/1098585

Today's issues should be fixed. I'll keep working on the patches for other extensions, more carefully this time.

VisualEditor message editcheck-falsepositives-link was renamed here. Now red links appear for this message: https://et.wikipedia.org/wiki/Eri:Viimased_muudatused?tagfilter=editcheck-references-activated

🤦‍♂️ The commit with the translation updates didn't make it into wmf.5. I'll backport it.

Change #1098990 had a related patch set uploaded (by Bartosz Dziewoński; author: L10n-bot):

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.5] Localisation updates (November 26)

https://gerrit.wikimedia.org/r/1098990

Oh, right, this is why via code search I couldn't find where exactly is old message name still used. I suppose it's no big deal then. Thanks for doing the backport anyway.

Change #1098990 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.5] Localisation updates (November 26)

https://gerrit.wikimedia.org/r/1098990

Mentioned in SAL (#wikimedia-operations) [2024-11-28T21:39:25Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1098990|Localisation updates (November 26) (T372175)]], [[gerrit:1098956|extend account creation lookup service to cover forced creations by others (T378401)]], [[gerrit:1098965|extend account creation backfill script to forced account creations by others (T378401)]], [[gerrit:1098929|ReportIncident: Setup $wgReportIncidentLocalLinks for ptwiki pilot deplo

Mentioned in SAL (#wikimedia-operations) [2024-11-28T21:53:42Z] <tgr@deploy2002> tgr, ariel, matmarex, mszabo: Backport for [[gerrit:1098990|Localisation updates (November 26) (T372175)]], [[gerrit:1098956|extend account creation lookup service to cover forced creations by others (T378401)]], [[gerrit:1098965|extend account creation backfill script to forced account creations by others (T378401)]], [[gerrit:1098929|ReportIncident: Setup $wgReportIncidentLocalLinks for ptwiki pilot

Mentioned in SAL (#wikimedia-operations) [2024-11-28T22:17:13Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1098990|Localisation updates (November 26) (T372175)]], [[gerrit:1098956|extend account creation lookup service to cover forced creations by others (T378401)]], [[gerrit:1098965|extend account creation backfill script to forced account creations by others (T378401)]], [[gerrit:1098929|ReportIncident: Setup $wgReportIncidentLocalLinks for ptwiki pilot depl

Change #1123746 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OAuth@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1123746

Change #1097489 merged by jenkins-bot:

[mediawiki/extensions/MobileApp@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1097489

Change #1124159 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/ContentTranslation@master] Separate tag help links from their labels (part 2)

https://gerrit.wikimedia.org/r/1124159

Change #1124160 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CommunityConfiguration@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124160

Change #1124162 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GrowthExperiments@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124162

Change #1124163 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Wikidata.org@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124163

Change #1124164 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaEvents@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124164

Change #1124165 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaMessages@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124165

That takes care of all Wikimedia-deployed extensions, I think I want to stop here.

Change #1124160 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124160

Change #1124162 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124162

Change #1124159 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Separate tag help links from their labels (part 2)

https://gerrit.wikimedia.org/r/1124159

Change #1124165 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124165

Change #1123746 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1123746

I just noticed a minor break at frwiki, I guess this task is the cause. Interface message which should contain the URL does not exist (yet?), so that breaks the link syntax:

image.png (231×542 px, 33 KB)

Sorry about that, it looks like some translation updates didn't make it in time to be deployed. This should be fixed next week.

Change #1124164 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124164

Change #1124163 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Separate tag help links from their labels

https://gerrit.wikimedia.org/r/1124163