Page MenuHomePhabricator

When the API fails, the Mentee overview module should fail visibly
Closed, ResolvedPublic

Description

When the API for Mentee overview fails, the Mentee overview module shows "No recently active mentees found", rather than visibly failing. Right now, the failure state looks like this:

image.png (1×1 px, 97 KB)

This is incorrect. When an error happens, it should be visible, to ensure users notice it as something unexpected (and something to complain about), rather than just waiting (as the wording tells them to).

Filling this task as a follow-up to T372164: Special:MentorDashboard broken.

The new error state should look like this:

image.png (844×956 px, 118 KB)

(I added the notification to reinforce "something is not working as expected" in a more visible way than a different wording in the empty screen)

Acceptance Criteria
  • When the Mentee overview module fails, an error message is shown rather than "No recently active mentees found".
  • When the Mentee overview module fails, an error message is logged in the client side errors channel (and noticed during chores).

Event Timeline

Change #1061126 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Fail visibly on errors

https://gerrit.wikimedia.org/r/1061126

FTR, I was testing this without the patch for T372164 applied. Might come useful, so noting it here.

Urbanecm_WMF raised the priority of this task from Low to Medium.Aug 12 2024, 10:41 AM

Change #1061126 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Fail visibly on errors

https://gerrit.wikimedia.org/r/1061126

Etonkovidova subscribed.

Checked on testwiki wmf.20 - the correct message for the api ("Unable to fetch mentees" ) error is displayed

Screen Shot 2024-08-30 at 3.32.26 PM.png (980×3 px, 206 KB)