Page MenuHomePhabricator

Remove wl-function-editor-footer in favor of the wl-publish-widget in the frontend vue files
Closed, ResolvedPublic

Description

Why: it adds an extra complexity layer between the wl-function-editor component and the wl-publish-widget which is not necessary.

How: move the logic to wl-function-editor.

Acceptance Criteria:

  • wl-function-editor-footer component + tests are gone
  • tests are updated

Event Timeline

Change #1133342 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Remove wl-function-editor-footer in favor of the wl-publish-widget in the frontend vue files

https://gerrit.wikimedia.org/r/1133342

DSmit-WMF changed the task status from Open to In Progress.Apr 2 2025, 9:32 AM

There's a bottom margin missing between the editor and the publish box now:

before:

Screenshot from 2025-04-02 17-03-42.png (1,205×648 px, 35 KB)

now:

Screenshot from 2025-04-02 17-03-31.png (1,221×604 px, 34 KB)

Not sure why .parse() is not converting ''' into <b>

I've added a wikitext link to the message, here's hows the same message shows with .parse() and with .text()

Screenshot from 2025-04-08 15-05-52.png (574×655 px, 71 KB)

The message is:

"wikilambda-publish-output-changed-impact-prompt": "You changed the output type of this function. '''All existing implementations and tests will be detached from the current function.''' Do you want to proceed? [[Z10000|Wikitext link]]",

As you see the link is working when called with .parse, but still no bold text.

Change #1133342 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove wl-function-editor-footer in favor of the wl-publish-widget in the frontend vue files

https://gerrit.wikimedia.org/r/1133342