Page MenuHomePhabricator

GrowthExperiments: Review issues possibly caused by recent eslint update
Closed, ResolvedPublic2 Estimated Story Points

Description

Recently, Special:MentorDashboard broke because of an eslint update (see T372164#10057975 for details). For mentor dashboard specifically, this happened because of differences between $.extend and Object.assign:

> $.extend({a: 1, b: 2}, {a: undefined, b: 1})
{a: 1, b: 1}
> Object.assign({a: 1, b: 2}, {a: undefined, b: 1})
{a: undefined, b: 1}

1057374: build: Update eslint-config-wikimedia to 0.28.2 is a large patch, containing several other changes of $.extend with Object.assign. We should review those entries for possible similar issues. If possible, we should also look at other changes, in case they are non-equivalent (similarly to this case).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.

FYI @Sgs @Michael @Cyndymediawiksim, I filled this as a follow-up to todays engineering sync. Boldly putting as High to Up Next, as we either do the review now, or it wouldn't be important (as we'd notice other bugs naturally).

KStoller-WMF set the point value for this task to 0.5.Aug 20 2024, 4:24 PM
KStoller-WMF subscribed.

Timebox to 1/2 a day.

Change #1064383 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Fix handling of undefined values after $.extend to Object.assign update

https://gerrit.wikimedia.org/r/1064383

KStoller-WMF changed the point value for this task from 0.5 to 2.Aug 21 2024, 4:11 PM

Change #1064383 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix handling of undefined values after $.extend to Object.assign update

https://gerrit.wikimedia.org/r/1064383