Align the "current" marker with the edit summary on Special:Contribs in Minerva
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tufor
	Aug 13 2024, 12:04 PM

Description

Steps to replicate the issue (include links if applicable):

Go to Special:Contribs on Minerva, for example:

https://pl.m.wikipedia.org/w/index.php?title=Specjalna%3AWk%C5%82ad&target=Tufor&namespace=0&uselang=en

What happens?:
The "current" tag/marker is not in line with the edit summary and simply looks ugly

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Newcomer notes

To work on this task you'll need to setup Minerva, MobileFrontend and MediaWiki.
To replicate you will need to create an account, make at least one edit, and then visit your contributions page.
The file to change is https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/skinStyles/mediawiki.interface.helpers.styles.less
Please use Gerrit to submit your patch.

QA Steps

Login to https://en.m.wikipedia.beta.wmflabs.org/ (mobile site)
Verify https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions&end=&limit=50&namespace=all&start=&tagfilter=&target=Jdlrobson "current" is vertically aligned with the edit summary and thanks icon

Derived Requirement

Ensure that the "current" tag on the Special
page in the Minerva skin is properly aligned with the edit summary and thanks icon.

BDD

Feature: Proper Alignment of "Current" Tag on Special:Contributions Page

Scenario: Ensure "current" tag is aligned with the edit summary and thanks icon

Given the user is viewing the Special:Contributions page in the Minerva skin
When the page displays the "current" tag next to the edit summary
Then the "current" tag should be vertically aligned with the edit summary and thanks icon

Test Steps

Test Case 1: Ensure "Current" Tag Is Vertically Aligned on SpecialPage

Log in to the Beta Wikipedia site.
Navigate to the Special page.
Verify the appearance of the "current" tag next to the edit summary.
✅❓❌⬜ AC1: Confirm that the "current" tag is vertically aligned with the edit summary and the thanks icon.

QA Results - Beta

AC	Status	Details
1	✅	T372392#10138640

QA Results - PROD

AC	Status	Details
1	✅	T372392#10177513

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
fixed alignment:"current" marker was not aligned with message	mediawiki/core	master	+2 -0
Fix alignment(Minerva):current marker was not aligned with message	mediawiki/skins/MinervaNeue	master	+5 -0
Fix alignment:current marker was not aligned with message	mediawiki/core	master	+9 -4

Customize query in gerrit

Related Objects

Mentioned In: T375654: Verify 1.43.0-wmf.23 deployment
Mentioned Here: T355991: Update ConfirmEdit README.md to use namespaced class names
T354822: [JS] Remove dispatch method

Event Timeline

Tufor created this task.Aug 13 2024, 12:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2024, 12:04 PM

Pppery moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Aug 17 2024, 4:54 AM

In Minerva, class mw-uctop (wrapping current) does not have the same styling that the comment has, causing this discrepancy.

Specifically , it is missing:

padding: 0.5em 0;
line-height: 1.4em;

Screenshot 2024-08-27 at 12.23.29.png (590×513 px, 65 KB)

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Jdlrobson updated the task description. (Show Details)Aug 27 2024, 3:47 PM

Hello,
Can you please assign this task to me.Thanks

Pppery assigned this task to Abhii5599.Sep 8 2024, 3:48 AM

@Abhii5599: Please do read previous messages to you: T354822#9513635, T355991#9509723. Please do not ask to assign tasks to you. Thanks.

@Aklapper

Apologies for not finishing the previous tasks. I will finish them asap.

Issue does not lie in the mentioned file i believe

The class mw-uctop is present in mediawiki/resources/src/mediawiki.special/special.less line-68

"current" marker gets aligned by changing the mw-uctop here.

The bug is in mediawiki repo and not in mediawiki-skins-MinervaNeue

The mentioned https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/skinStyles/mediawiki.interface.helpers.styles.less does not have any related fix. I scanned the whole repo.

Please advise if I am on correct path.

Change #1071361 had a related patch set uploaded (by Ammarpad; author: Abhii5599):

[mediawiki/core@master] Fix alignment:current marker was not aligned with message

https://gerrit.wikimedia.org/r/1071361

gerritbot added a project: Patch-For-Review.Sep 9 2024, 5:56 AM

Change #1071361 abandoned by Abhii5599:

[mediawiki/core@master] Fix alignment:current marker was not aligned with message

https://gerrit.wikimedia.org/r/1071361

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2024, 3:30 PM

Change #1071627 had a related patch set uploaded (by Jdlrobson; author: Abhii5599):

[mediawiki/core@master] Fix alignment:current marker was not aligned with message

https://gerrit.wikimedia.org/r/1071627

gerritbot added a project: Patch-For-Review.Sep 9 2024, 8:02 PM

Change #1071735 had a related patch set uploaded (by Jdlrobson; author: Abhii5599):

[mediawiki/skins/MinervaNeue@master] Fix alignment(Minerva):current marker was not aligned with message

https://gerrit.wikimedia.org/r/1071735

Jdlrobson reassigned this task from Abhii5599 to Edtadros.Sep 10 2024, 9:08 PM

Jdlrobson lowered the priority of this task from Medium to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Unplanned-Sprint-Work, Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 5).

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 5) board.

Change #1071735 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix alignment(Minerva):current marker was not aligned with message

https://gerrit.wikimedia.org/r/1071735

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 10 2024, 11:00 PM

After this fix, when the edit summary is longer than one line, the 'current' marker appears on a new line instead of aligning next to the summary, regardless of available space. Not sure if it's desired behavior though.

https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions&end=&limit=50&namespace=all&start=&tagfilter=&target=Jdlrobson

In T372392#10136703, @Tufor wrote:

After this fix, when the edit summary is longer than one line, the 'current' marker appears on a new line instead of aligning next to the summary, regardless of available space. Not sure if it's desired behavior though.

https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions&end=&limit=50&namespace=all&start=&tagfilter=&target=Jdlrobson

This is the current behaviour for very long edit summaries. See https://en.m.wikipedia.org/w/index.php?title=Special:Contributions&end=&limit=50&namespace=all&start=&tagfilter=&target=Jdlrobson for reference. This is not introduced by this change.

Screenshot 2024-09-11 at 8.53.24 AM.png (535×1 px, 107 KB)

GMikesell-WMF claimed this task.Sep 11 2024, 6:42 PM

GMikesell-WMF updated Other Assignee, added: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF added a subscriber: Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.6.1
Browser: Chrome 128
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure "Current" Tag Is Vertically Aligned on SpecialPage

Log in to the Beta Wikipedia site.
Navigate to the Special page.
Verify the appearance of the "current" tag next to the edit summary.
✅ AC1: Confirm that the "current" tag is vertically aligned with the edit summary and the thanks icon.

Light	Dark

GMikesell-WMF updated the task description. (Show Details)Sep 11 2024, 6:49 PM

Yep that's a pass!

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Sep 11 2024, 7:01 PM

GMikesell-WMF updated Other Assignee, removed: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF subscribed.

Jdlrobson closed this task as Resolved.Sep 12 2024, 5:01 PM

Jdlrobson claimed this task.

GMikesell-WMF mentioned this in T375654: Verify 1.43.0-wmf.23 deployment.Sep 25 2024, 7:02 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 15.0
Browser: Chrome 129
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://pl.m.wikipedia.org/w/index.php?title=Specjalna%3AWk%C5%82ad&target=Tufor&namespace=0&uselang=en
https://pl.m.wikipedia.org/w/index.php?title=Specjalna%3AWk%C5%82ad&target=Tufor&namespace=0&uselang=en&minervanightmode=1

Test Steps

Test Case 1: Ensure "Current" Tag Is Vertically Aligned on SpecialPage

Log in to the PROD Wikipedia site.
Navigate to the Special page.
Verify the appearance of the "current" tag next to the edit summary.
✅ AC1: Confirm that the "current" tag is vertically aligned with the edit summary and the thanks icon.

Light	Dark

GMikesell-WMF added a project: Verified.Sep 25 2024, 8:14 PM

GMikesell-WMF updated the task description. (Show Details)

	F57499748: Screenshot 2024-09-11 at 8.53.24 AM.png
	Sep 11 2024, 3:53 PM

	F57499261: image.png
	Sep 11 2024, 9:49 AM

	F57484835: image.png
	Sep 8 2024, 9:21 PM

	F57484833: image.png
	Sep 8 2024, 9:21 PM

Align the "current" marker with the edit summary on Special:Contribs in MinervaClosed, ResolvedPublicActions

Description

QA Steps

Derived Requirement

BDD

Test Steps

QA Results - Beta

QA Results - PROD

Details

Related Objects

Event Timeline

Test Result - Beta

Test Steps

Test Result - PROD

Test Steps

Align the "current" marker with the edit summary on Special:Contribs in Minerva
Closed, ResolvedPublic
Actions