Page MenuHomePhabricator
Create Task
Maniphest T372508

Update Adyen listener to deal with Gravy transactions
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Drop all Gravy-initiated donations
Listen for all ipn messages on Gravy-initiated donations, instead of send to adyen, drop it to avoid duplicate audit

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add additionalData to adyen message to parsewikimedia/fundraising/SmashPigmaster+4 -0
Rename Gr4vy to Gravy to avoid the 4 sneaking back in... silly 4.wikimedia/fundraising/SmashPigmaster+14 -14
if ipn message contains additionalData gr4vywikimedia/fundraising/SmashPigmaster+167 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT364501 Gravy Integration
 ResolvedAnnWFT372508 Update Adyen listener to deal with Gravy transactions

Event Timeline

Ejegg created this task.Aug 14 2024, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2024, 7:53 PM
Ejegg added a parent task: T364501: Gravy Integration.Aug 14 2024, 7:53 PM
AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Aug 19 2024, 8:01 PM
jgleeson subscribed.Aug 21 2024, 7:56 PM

Let's drop these right away instead of letting them get on the jobs-adyen queue and filter out that way.

Dwisehaupt set the point value for this task to 2.Aug 26 2024, 8:06 PM
AKanji-WMF moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Aug 27 2024, 7:10 PM
AKanji-WMF added a project: Fundraising Sprint: quietlyBreakingThings().Aug 27 2024, 7:42 PM
AnnWF claimed this task.Sep 5 2024, 3:46 PM
AnnWF moved this task from Backlog to Doing on the Fundraising Sprint: quietlyBreakingThings() board.Sep 9 2024, 5:08 PM
gerritbot added a comment.Sep 9 2024, 6:48 PM

Change #1071680 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] if ipn message contains additionalData gr4vy

https://gerrit.wikimedia.org/r/1071680

gerritbot added a project: Patch-For-Review.Sep 9 2024, 6:48 PM
AnnWF moved this task from Doing to Ready for Review on the Fundraising Sprint: quietlyBreakingThings() board.Sep 9 2024, 6:50 PM
jgleeson added a comment.Sep 10 2024, 4:15 PM

We might need to broaden the scope of this ticket and block all IPNs that include the Gravy metadata.

I was just testing gravy refunds where the backend processor is Adyen, and I noticed the RefundQueueConsumer tried to process two refunds for the same payment, one for the gravy refund message and one for the Adyen refund message.

The adyen refund failed due to:

18   │ 2024-09-10 15:40:02,734 ERROR   civicrm.wmf.ERROR: wmf_common: Failure while processing message: MISSING_PREDECESSOR Parent not found: ADYEN CWTBF3WXXSLVZ569
AKanji-WMF edited projects, added Fundraising Sprint: reasonablyAccurate(); removed Fundraising Sprint: quietlyBreakingThings().Sep 10 2024, 8:09 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint: reasonablyAccurate() board.Sep 11 2024, 11:19 AM
AnnWF moved this task from Doing to Ready for Review on the Fundraising Sprint: reasonablyAccurate() board.Sep 12 2024, 3:59 PM
AnnWF moved this task from Ready for Review to Doing on the Fundraising Sprint: reasonablyAccurate() board.Sep 12 2024, 4:05 PM
AnnWF updated the task description. (Show Details)Sep 12 2024, 9:52 PM
AnnWF moved this task from Doing to Ready for Review on the Fundraising Sprint: reasonablyAccurate() board.Sep 20 2024, 2:34 AM
jgleeson moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint: reasonablyAccurate() board.Sep 20 2024, 12:20 PM
gerritbot added a comment.Sep 20 2024, 1:32 PM

Change #1074424 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/SmashPig@master] Rename Gr4vy to Gravy to avoid the 4 sneaking back in... silly 4.

https://gerrit.wikimedia.org/r/1074424

jgleeson moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint: reasonablyAccurate() board.Sep 20 2024, 1:34 PM
gerritbot added a comment.Sep 20 2024, 9:37 PM

Change #1071680 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] if ipn message contains additionalData gr4vy

https://gerrit.wikimedia.org/r/1071680

gerritbot added a comment.Sep 20 2024, 9:37 PM

Change #1074424 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Rename Gr4vy to Gravy to avoid the 4 sneaking back in... silly 4.

https://gerrit.wikimedia.org/r/1074424

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2024, 10:30 PM
gerritbot added a comment.Sep 23 2024, 6:38 PM

Change #1075063 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] Add additionalData to adyen message to parse

https://gerrit.wikimedia.org/r/1075063

gerritbot added a project: Patch-For-Review.Sep 23 2024, 6:38 PM
gerritbot added a comment.Sep 23 2024, 6:43 PM

Change #1075063 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add additionalData to adyen message to parse

https://gerrit.wikimedia.org/r/1075063

AnnWF moved this task from Pending Deployment to Done on the Fundraising Sprint: reasonablyAccurate() board.Sep 23 2024, 6:58 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 7:30 PM
XenoRyet closed this task as Resolved.Sep 24 2024, 7:08 PM
XenoRyet set Final Story Points to 4.
AnnWF mentioned this in T379196: only use gravy paypal ipn message drop the paypal_ec duplicate one.Nov 6 2024, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits