Page MenuHomePhabricator
Create Task
Maniphest T372592

Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools
Open, HighPublic
Actions

Description

Follow-up to T372499.

https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/3ec0789d06c2473e5a4c5a951a402166720ca49a/includes/CommentFormatter.php#417

		// Temporary hack to deal with T351461#9358034: this should be a
		// call to `setJsConfigVar` but Parsoid is currently reprocessing
		// content from extensions. (T372592)
		// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
		@$pout->addJsConfigVars( 'wgDiscussionToolsPageThreads', $threadsJSON );

(see T351461#9358034 and T372592)

addJsConfigVars() is hard-deprecated since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/943642 (August 2024). A solution is needed somewhat urgently.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add title and "isMessage" outputflags to ParserOutputmediawiki/coremaster+17 -1
[DNM] Moves legacy processing to ParserOutputPostCacheTransformmediawiki/extensions/DiscussionToolsmaster+15 -35
Always set a value for isEmptyTalkPage when transforming htmlmediawiki/extensions/DiscussionToolsmaster+6 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT305161 Hard-deprecate and remove @deprecated methods from ParserOutput
 OpenihurbainT372592 Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools
 ResolvedPRODUCTION ERRORmatmarexT372499 InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024)
 OpenNoneT376183 Create new AfterArticleParse hook for Discussion Tools
 ResolvedihurbainT348255 Parser cache infrastructure for OutputTransform
 ResolvedihurbainT348253 Create MediaWiki\ParserOutputTransform\DefaultOutputTransform
 ResolvedcscottT348254 Add ParserOutput::getContentHolder()
 ResolvedihurbainT347062 Create ContentHolder interface
 ResolvedcscottT346829 JsonCodec should be a standalone library
 ResolvedihurbainT404459 Use ContentHolder to speed up Parsoid-related OutputTransform stages
 OpenNoneT348853 Deprecate null skin on DefaultOutputTransform
 OpencscottT380517 Make Parsoid language conversion into an OutputTransform pass
 OpenBUG REPORTNoneT400140 Existed links render as redlinks in Template
 OpenihurbainT410916 Allow requesting postprocessed output for some/many/most/all APIs which accept a ParserOption (in some form) and emit a ParserOutput (in some form)
 ResolvedihurbainT410919 Allow ParserOutputAccess to generate (and cache) postprocessed output for use in Article read views
 ResolvedihurbainT410923 Clone ParserOutput in Article before post-processing
 OpenihurbainT412803 Tweak unsafe post-processing cache keys
 ResolvedcscottT413227 Section edit links appear in wrong user interface language on Parsoid Read View wikis
 OpenihurbainT414359 Use postprocessing cache in FlaggedRevisions
 OpenNoneT411401 Eliminate double-parse and double-postprocess in CommonsMetadata
 ResolvedPRODUCTION ERRORcscottT412959 Logstash poolcounter warnings "Usage error: You may only aquire a single non-nowait lock" on wikis with post-processing cache enabled
 OpenihurbainT413795 Use ParserOptions in the post-processing pipeline rather than the options array

Event Timeline

matmarex created this task.Aug 15 2024, 7:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2024, 7:46 PM
matmarex updated the task description. (Show Details)Aug 15 2024, 7:48 PM
matmarex added a parent task: T305161: Hard-deprecate and remove @deprecated methods from ParserOutput.Aug 15 2024, 7:53 PM
matmarex updated the task description. (Show Details)Aug 15 2024, 7:55 PM
matmarex added a subtask: T372499: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024).Aug 15 2024, 8:36 PM
Jdforrester-WMF triaged this task as High priority.Aug 15 2024, 9:10 PM
Jdforrester-WMF added a project: Content-Transform-Team.
matmarex closed subtask T372499: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024) as Resolved.Aug 17 2024, 12:26 PM
cscott claimed this task.Aug 19 2024, 3:14 PM
cscott added a project: Content-Transform-Team-WIP.
MSantos removed a project: Content-Transform-Team.Aug 22 2024, 2:28 PM
matmarex mentioned this in T371125: When using Parsoid rendering, DiscussionTools "empty state" appears on all talk pages.Aug 22 2024, 6:43 PM
MSantos added a project: Essential-Work.Aug 26 2024, 2:22 PM
cscott moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Aug 26 2024, 3:14 PM
gerritbot added a comment.Sep 20 2024, 10:29 PM

Change #1074544 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/DiscussionTools@master] Always set a value for isEmptyTalkPage when transforming html

https://gerrit.wikimedia.org/r/1074544

gerritbot added a project: Patch-For-Review.Sep 20 2024, 10:29 PM
gerritbot added a comment.Sep 23 2024, 6:43 PM

Change #1074544 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Always set a value for isEmptyTalkPage when transforming html

https://gerrit.wikimedia.org/r/1074544

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 23 2024, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 7:30 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Sep 26 2024, 2:22 PM
ABreault-WMF added a subtask: T376183: Create new AfterArticleParse hook for Discussion Tools.Oct 1 2024, 7:54 PM
ihurbain edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team-WIP.Apr 11 2025, 11:37 AM
Jdforrester-WMF subscribed.Oct 15 2025, 4:41 PM

I forgot about this issue, and only caught it in (non-gated) tests for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1196123.

Is the re-processing done yet? Can we remove this final usage?

cscott updated the task description. (Show Details)Tue, Jan 6, 6:37 PM
ihurbain claimed this task.Fri, Jan 9, 10:19 AM
ihurbain added a subscriber: cscott.
gerritbot added a comment.Fri, Jan 9, 10:25 AM

Change #1224904 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add prefixed title to ParserOutput (like it is done in Parsoid)

https://gerrit.wikimedia.org/r/1224904

gerritbot added a project: Patch-For-Review.Fri, Jan 9, 10:25 AM
gerritbot added a comment.Fri, Jan 9, 5:47 PM

Change #1225002 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/DiscussionTools@master] [DNM] Moves legacy processing to ParserOutputPostCacheTransform

https://gerrit.wikimedia.org/r/1225002

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits