Page MenuHomePhabricator
Create Task
Maniphest T372592

Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools
Open, HighPublic
Actions

Description

Follow-up to T372499.

https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/3ec0789d06c2473e5a4c5a951a402166720ca49a/includes/CommentFormatter.php#417

		// Temporary hack to deal with T351461#9358034: this should be a
		// call to `setJsConfigVar` but Parsoid is currently reprocessing
		// content from extensions. (T372592)
		// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
		@$pout->addJsConfigVars( 'wgDiscussionToolsPageThreads', $threadsJSON );

(see T351461#9358034 and T372592)

addJsConfigVars() is hard-deprecated since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/943642 (August 2024). A solution is needed somewhat urgently.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enables legacy processing in ParserOutputPostCacheTransform when cachedmediawiki/extensions/DiscussionToolsmaster+41 -12
Enables legacy processing in ParserOutputPostCacheTransform when cachedmediawiki/extensions/DiscussionToolswmf/1.46.0-wmf.19+41 -12
Make the ParserOptions accessible to onParserOutputPostCacheTransformmediawiki/coremaster+24 -2
Add title and "isMessage" outputflags to ParserOutputmediawiki/coremaster+17 -1
Add a hook to allow DT to opt-in legacy parser postprocessing cachemediawiki/coremaster+44 -9
Always set a value for isEmptyTalkPage when transforming htmlmediawiki/extensions/DiscussionToolsmaster+6 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT305161 Hard-deprecate and remove @deprecated methods from ParserOutput
 OpenihurbainT372592 Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools
 ResolvedPRODUCTION ERRORmatmarexT372499 InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024)
 ResolvedihurbainT376183 Use postprocessing cache for Discussion Tools
 ResolvedihurbainT348255 Parser cache infrastructure for OutputTransform
 ResolvedihurbainT348253 Create MediaWiki\ParserOutputTransform\DefaultOutputTransform
 ResolvedcscottT348254 Add ParserOutput::getContentHolder()
 ResolvedihurbainT347062 Create ContentHolder interface
 ResolvedcscottT346829 JsonCodec should be a standalone library
 ResolvedihurbainT404459 Use ContentHolder to speed up Parsoid-related OutputTransform stages
 OpenNoneT348853 Deprecate null skin on DefaultOutputTransform
 ResolvedcscottT380517 Make Parsoid language conversion into an OutputTransform pass
 ResolvedBUG REPORTcscottT400140 Existed links render as redlinks in Template
 ResolvedcscottT415435 Add temporary URL request parameter to opt-in to the new Parsoid LanguageConverter implementation
 ResolvedcscottT267067 Make language variant a parser option
 OpenNoneT346996 Move page view language detection logic / functions out of LanguageConverter class and stop using global state
 ResolvedKrinkleT299369 Consider removing global $userLang from onPageContentLanguage hook
 ResolvedKrinkleT341244 ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir
 Resolved• DAlangi_WMFT350806 Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
OpencscottT416104 Use proper variant in ParsoidLocalization on messages localized into the page language
 OpenihurbainT410916 Allow requesting postprocessed output for some/many/most/all APIs which accept a ParserOption (in some form) and emit a ParserOutput (in some form)
 ResolvedihurbainT410919 Allow ParserOutputAccess to generate (and cache) postprocessed output for use in Article read views
 ResolvedihurbainT410923 Clone ParserOutput in Article before post-processing
 ResolvedihurbainT412803 Tweak unsafe post-processing cache keys
 ResolvedcscottT413227 Section edit links appear in wrong user interface language on Parsoid Read View wikis
 ResolvedihurbainT414359 Use postprocessing cache in FlaggedRevisions
 OpenNoneT411401 Eliminate double-parse and double-postprocess in CommonsMetadata
 ResolvedPRODUCTION ERRORcscottT412959 Logstash poolcounter warnings "Usage error: You may only aquire a single non-nowait lock" on wikis with post-processing cache enabled
 OpenihurbainT413795 Use ParserOptions in the post-processing pipeline rather than the options array

Event Timeline

matmarex created this task.Aug 15 2024, 7:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2024, 7:46 PM
matmarex updated the task description. (Show Details)Aug 15 2024, 7:48 PM
matmarex added a parent task: T305161: Hard-deprecate and remove @deprecated methods from ParserOutput.Aug 15 2024, 7:53 PM
matmarex updated the task description. (Show Details)Aug 15 2024, 7:55 PM
matmarex added a subtask: T372499: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024).Aug 15 2024, 8:36 PM
Jdforrester-WMF triaged this task as High priority.Aug 15 2024, 9:10 PM
Jdforrester-WMF added a project: Content-Transform-Team.
matmarex closed subtask T372499: InvalidArgumentException: Multiple conflicting values given for wgDiscussionToolsPageThreads (August 2024) as Resolved.Aug 17 2024, 12:26 PM
cscott claimed this task.Aug 19 2024, 3:14 PM
cscott added a project: Content-Transform-Team-WIP.
MSantos removed a project: Content-Transform-Team.Aug 22 2024, 2:28 PM
matmarex mentioned this in T371125: When using Parsoid rendering, DiscussionTools "empty state" appears on all talk pages.Aug 22 2024, 6:43 PM
MSantos added a project: Essential-Work.Aug 26 2024, 2:22 PM
cscott moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Aug 26 2024, 3:14 PM
gerritbot added a comment.Sep 20 2024, 10:29 PM

Change #1074544 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/DiscussionTools@master] Always set a value for isEmptyTalkPage when transforming html

https://gerrit.wikimedia.org/r/1074544

gerritbot added a project: Patch-For-Review.Sep 20 2024, 10:29 PM
gerritbot added a comment.Sep 23 2024, 6:43 PM

Change #1074544 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Always set a value for isEmptyTalkPage when transforming html

https://gerrit.wikimedia.org/r/1074544

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 23 2024, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 7:30 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Sep 26 2024, 2:22 PM
ABreault-WMF added a subtask: T376183: Use postprocessing cache for Discussion Tools.Oct 1 2024, 7:54 PM
ihurbain edited projects, added: Content-Transform-Team (Work In Progress); removed: Content-Transform-Team-WIP.Apr 11 2025, 11:37 AM
Jdforrester-WMF subscribed.Oct 15 2025, 4:41 PM

I forgot about this issue, and only caught it in (non-gated) tests for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1196123.

Is the re-processing done yet? Can we remove this final usage?

cscott updated the task description. (Show Details)Jan 6 2026, 6:37 PM
ihurbain claimed this task.Jan 9 2026, 10:19 AM
ihurbain added a subscriber: cscott.
gerritbot added a comment.Jan 9 2026, 10:25 AM

Change #1224904 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add prefixed title to ParserOutput (like it is done in Parsoid)

https://gerrit.wikimedia.org/r/1224904

gerritbot added a project: Patch-For-Review.Jan 9 2026, 10:25 AM
gerritbot added a comment.Jan 9 2026, 5:47 PM

Change #1225002 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/DiscussionTools@master] [DNM] Moves legacy processing to ParserOutputPostCacheTransform

https://gerrit.wikimedia.org/r/1225002

gerritbot added a comment.Jan 13 2026, 5:45 PM

Change #1226310 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add a hook to allow DT to opt-in legacy parser postprocessing cache

https://gerrit.wikimedia.org/r/1226310

gerritbot added a comment.Jan 26 2026, 2:10 PM

Change #1233195 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Adds "IS_INTERFACE" as a flag of the ParserOutput

https://gerrit.wikimedia.org/r/1233195

gerritbot added a comment.Jan 27 2026, 12:28 PM

Change #1226310 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/core@master] Add a hook to allow DT to opt-in legacy parser postprocessing cache

Reason:

not needed

https://gerrit.wikimedia.org/r/1226310

Bugreporter2 awarded a token.Jan 31 2026, 12:02 PM
gerritbot added a comment.Feb 6 2026, 10:34 AM

Change #1224904 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/core@master] Add title and "isMessage" outputflags to ParserOutput

Reason:

in favor of title added by cscott and ismessage being added to options instead

https://gerrit.wikimedia.org/r/1224904

gerritbot added a comment.Feb 7 2026, 1:07 AM

Change #1233195 merged by jenkins-bot:

[mediawiki/core@master] Make the ParserOptions accessible to onParserOutputPostCacheTransform

https://gerrit.wikimedia.org/r/1233195

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Feb 7 2026, 2:00 AM
gerritbot added a comment.Mar 10 2026, 1:54 PM

Change #1225002 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enables legacy processing in ParserOutputPostCacheTransform when cached

https://gerrit.wikimedia.org/r/1225002

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Mar 10 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 10 2026, 2:30 PM
gerritbot added a comment.Mar 10 2026, 4:54 PM

Change #1250007 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/DiscussionTools@wmf/1.46.0-wmf.19] Enables legacy processing in ParserOutputPostCacheTransform when cached

https://gerrit.wikimedia.org/r/1250007

gerritbot added a project: Patch-For-Review.Mar 10 2026, 4:54 PM
gerritbot added a comment.Mar 10 2026, 8:23 PM

Change #1250007 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.46.0-wmf.19] Enables legacy processing in ParserOutputPostCacheTransform when cached

https://gerrit.wikimedia.org/r/1250007

Stashbot added a comment.Mar 10 2026, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-10T20:25:45Z] <jforrester@deploy2002> Started scap sync-world: Backport for [[gerrit:1240012|Enable personal main menu to all users in Minerva Neue skin (T413912)]], [[gerrit:1250007|Enables legacy processing in ParserOutputPostCacheTransform when cached (T372592)]], [[gerrit:1250015|Parser: Raise minimum TTL from 30 min to 'next midnight' in miser mode (T416616 T416540 T419439)]]

Stashbot mentioned this in T416616: Create new cache-friendly lua/parser function for "is today before X date" and "is today after X date".Mar 10 2026, 8:25 PM
Stashbot mentioned this in T419439: Clean up Cache Expiry computation.
Stashbot mentioned this in T413912: Deployment: Promote advanced user menu to all users.
Stashbot mentioned this in T416540: Mean MediaWiki backend latency increased by 60% between October and December 2025.
Stashbot added a comment.Mar 10 2026, 8:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-10T20:27:51Z] <jforrester@deploy2002> jforrester, cscott, bwang: Backport for [[gerrit:1240012|Enable personal main menu to all users in Minerva Neue skin (T413912)]], [[gerrit:1250007|Enables legacy processing in ParserOutputPostCacheTransform when cached (T372592)]], [[gerrit:1250015|Parser: Raise minimum TTL from 30 min to 'next midnight' in miser mode (T416616 T416540 T419439)]] synced to the testservers (see https://wikitech.wi

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2026, 8:31 PM
Stashbot added a comment.Mar 10 2026, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-10T20:38:43Z] <jforrester@deploy2002> Finished scap sync-world: Backport for [[gerrit:1240012|Enable personal main menu to all users in Minerva Neue skin (T413912)]], [[gerrit:1250007|Enables legacy processing in ParserOutputPostCacheTransform when cached (T372592)]], [[gerrit:1250015|Parser: Raise minimum TTL from 30 min to 'next midnight' in miser mode (T416616 T416540 T419439)]] (duration: 12m 58s)

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 10 2026, 9:01 PM
cscott mentioned this in T419830: Signatures aren't properly recognized on ruwiktionary and other projects when using Parsoid, resulting in a missing [ reply ] button.Mar 12 2026, 2:10 PM
ihurbain closed subtask T376183: Use postprocessing cache for Discussion Tools as Resolved.May 5 2026, 11:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits