Page MenuHomePhabricator

Extend x-wikimedia-debug-routing.lua to support PHP 8.1 mw-debug deployment
Closed, ResolvedPublic

Description

Once we have a PHP 8.1-flavored mw-debug deployment (T372604), extend x-wikimedia-debug-routing.lua [0] to support it as a backend.

This is a pretty straightforward change, but needs to wait until we've chosen a service name and port.

Once that's done (and we've validated manually that it works as expected) we'll also need to update debug.json [1] in order for the extension to offer it as an option.

[0] https://gerrit.wikimedia.org/g/operations/puppet/+/refs/heads/production/modules/profile/files/trafficserver/x-wikimedia-debug-routing.lua

[1] https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/debug.json

Related Objects

StatusSubtypeAssignedTask
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
StalledNone
StalledNone
OpenNone
OpenNone
StalledNone
In ProgressKrinkle
In ProgressScott_French
ResolvedMSantos
ResolvedScott_French
ResolvedScott_French
Resolveddduvall
ResolvedClement_Goubert
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French

Event Timeline

Change #1072638 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] P:trafficserver: extend x-wikimedia-debug-routing for mwdebug-next

https://gerrit.wikimedia.org/r/1072638

Change #1076848 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/mediawiki-config@master] debug.json: add support for mwdebug-next

https://gerrit.wikimedia.org/r/1076848

Mentioned in SAL (#wikimedia-operations) [2024-10-22T19:40:31Z] <swfrench-wmf> disabling puppet on A:cp-text before merging ATS Lua changes - T372605

Change #1072638 merged by Scott French:

[operations/puppet@production] P:trafficserver: extend x-wikimedia-debug-routing for mwdebug-next

https://gerrit.wikimedia.org/r/1072638

Mentioned in SAL (#wikimedia-operations) [2024-10-22T19:54:31Z] <swfrench-wmf> running puppet on A:cp-text (-b11) after validating ATS Lua changes on cp4040 - T372605

This now works via the x-wikimedia-debug "k8s-mwdebug-next" backend (plus -codfw and -eqiad variants). To avoid any confusion about the current state, I'm going to wait to merge / deploy the mediawiki-config debug.json patch until we actually have 8.1 live there.

Scott_French added a subscriber: Krinkle.

8.1 is live as of yesterday and passes basic httpbb checks (T372604#10318811). I think it makes sense to include it in debug.json (https://gerrit.wikimedia.org/r/1076848) to facilitate testing (T379986).

@Krinkle would you have any concerns about moving ahead with that, or tests you'd recommend performing before-hand?

Edit: After some discussion out of band, there is at least one open task that needs resolved before PHP 8.1 is "ready to test" (work ongoing). @Krinkle will follow up here when that work is complete, at which point we'll merge the change to include -next in the WikimediaDebug backend list.

Change #1076848 merged by jenkins-bot:

[operations/mediawiki-config@master] debug.json: add support for mwdebug-next

https://gerrit.wikimedia.org/r/1076848

Mentioned in SAL (#wikimedia-operations) [2024-11-26T20:17:13Z] <swfrench@deploy2002> Started scap sync-world: Backport for [[gerrit:1076848|debug.json: add support for mwdebug-next (T372605)]]

Thanks to @Krinkle for confirming that testing is now unblocked. Given that, I'm going ahead and merging the debug.json changes to better facilitate that.

Mentioned in SAL (#wikimedia-operations) [2024-11-26T20:23:16Z] <swfrench@deploy2002> swfrench: Backport for [[gerrit:1076848|debug.json: add support for mwdebug-next (T372605)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-26T20:31:34Z] <swfrench@deploy2002> Finished scap sync-world: Backport for [[gerrit:1076848|debug.json: add support for mwdebug-next (T372605)]] (duration: 14m 21s)

The debug.json changes are live, and I've validated that selecting "k8s-mwdebug-next" (or similar) in the browser extension has the desired effect.