Page MenuHomePhabricator
Create Task
Maniphest T372748

Apply `:focus-visible` in Card with link and Accordion
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

In T370503 we've decided to use :focus-visible (make the focus visible just when navigating with the keyboard) in those Codex components navigating to other pages or sections. Since :focus-visible is already implemented in Link and Tabs, we need to apply the :focus-visible in the following remaining components:

  • Card with link. We could evaluate applying :focus-visible on Cards including navigation.
  • Accordion. It expands/collapses content within the page, so the :focus-visible approach could be applied as well in this component.

Acceptance criteria for Done

  • Implement :focus-visible in those Codex components navigating to other pages or sections
    • Card with link
    • Accordion

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update Codex from v1.20.0 to v1.20.1Anne Tomasevichmediawiki/coremaster+167 -81
styles: Implement `:focus-visible` in Card and Accordion componentsGauriGuptaadesign/codexmain+26 -10
Customize query in gerrit

Related Objects

Event Timeline

bmartinezcalvo created this task.Aug 19 2024, 10:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2024, 10:39 AM
bmartinezcalvo mentioned this in T370503: Explore using focus-visible in the rest of Codex components.Aug 19 2024, 10:41 AM
bmartinezcalvo updated the task description. (Show Details)
bmartinezcalvo moved this task from Inbox to Backlog on the Design-System-Team board.Aug 19 2024, 10:44 AM
CCiufo-WMF added a project: good first task.Aug 22 2024, 5:46 PM
Restricted Application added a comment. · View Herald TranscriptAug 22 2024, 5:46 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

CCiufo-WMF moved this task from Backlog to Up Next on the Design-System-Team board.Aug 22 2024, 5:48 PM
Eslam_AbdElhakem subscribed.Aug 22 2024, 6:46 PM
CCiufo-WMF triaged this task as Low priority.Aug 23 2024, 3:58 PM
CCiufo-WMF moved this task from Up Next to Needs Refinement on the Design-System-Team board.Aug 23 2024, 7:49 PM
Tomaspeter92 subscribed.Sep 3 2024, 5:08 AM
ChandraPratap25 claimed this task.Sep 12 2024, 3:42 AM
ChandraPratap25 subscribed.

I want to Work on This bug

Volker_E updated the task description. (Show Details)Sep 12 2024, 9:17 AM
Volker_E added a project: CSS.
Volker_E updated the task description. (Show Details)

@ChandraPratap25 Please feel free to provide a patch!

Volker_E renamed this task from Apply focus-visible in Card and Accordion to Apply `:focus-visible` in Card with link and Accordion.Sep 12 2024, 9:20 AM
gerritbot added a comment.Nov 20 2024, 11:07 AM

Change #1093301 had a related patch set uploaded (by GauriGuptaa; author: GauriGuptaa):

[design/codex@main] T372748: Implement :focus-visible in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

gerritbot added a project: Patch-For-Review.Nov 20 2024, 11:08 AM
Volker_E removed ChandraPratap25 as the assignee of this task.Nov 20 2024, 5:20 PM
Volker_E added a subscriber: GauriGupta.

Removing @ChandraPratap25 due to inactivity, I assume @GauriGupta is the Phab profile name connected to the patch author, correct? :)

Volker_E set the point value for this task to 1.Nov 21 2024, 9:20 PM
Volker_E moved this task from Needs Refinement to Up Next on the Design-System-Team board.
CCiufo-WMF assigned this task to GauriGupta.Nov 25 2024, 3:55 PM
Volker_E added a comment.Nov 25 2024, 5:13 PM

@GauriGupta Do you have time to finalize the work on this in the upcoming two weeks?

lwatson edited projects, added: Design-System-Team (DST-Sprint-37 (2024-11-25 to 2024-12-06)); removed: Design-System-Team.Nov 25 2024, 6:39 PM
CCiufo-WMF moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-37 (2024-11-25 to 2024-12-06)) board.Nov 25 2024, 6:39 PM
Volker_E added a comment.Dec 5 2024, 9:10 PM

Hi @GauriGupta! Am I assuming right, that you've run out of time to continue working on this? If we won't hear back in the next 24 hours from you, I'd take the patch and finalize it with you tagged as co-author.

Volker_E added a comment.Dec 6 2024, 10:37 PM

fyi, @GauriGupta told me in a personal email that they gonna will work on the patch next day(s).

AnneT edited projects, added: Design-System-Team; removed: Design-System-Team (DST-Sprint-37 (2024-11-25 to 2024-12-06)).Dec 9 2024, 5:47 PM
gerritbot added a comment.Dec 20 2024, 4:08 AM

Change #1093301 abandoned by GauriGuptaa:

[design/codex@main] T372748: Implement :focus-visible in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2024, 4:30 AM
gerritbot added a comment.Dec 23 2024, 5:06 AM

Change #1093301 restored by VolkerE:

[design/codex@main] T372748: Implement :focus-visible in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

gerritbot added a project: Patch-For-Review.Dec 23 2024, 5:06 AM
gerritbot added a comment.Dec 25 2024, 7:33 AM

Change #1093301 abandoned by GauriGuptaa:

[design/codex@main] T372748: Implement :focus-visible in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

gerritbot added a comment.Jan 7 2025, 5:03 AM

Change #1093301 restored by VolkerE:

[design/codex@main] T372748: Implement :focus-visible in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

gerritbot added a comment.Jan 7 2025, 5:10 AM

Change #1093301 had a related patch set uploaded (by VolkerE; author: GauriGuptaa):

[design/codex@main] styles: Implement `:focus-visible` in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

Volker_E claimed this task.Jan 7 2025, 5:59 AM
Volker_E edited projects, added: Design-System-Team (DST-Sprint-39 (2025-01-06 to 2025-01-17)); removed: Design-System-Team.
Volker_E moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-39 (2025-01-06 to 2025-01-17)) board.Jan 8 2025, 6:25 PM
Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-39 (2025-01-06 to 2025-01-17)) board.Jan 24 2025, 4:38 PM
gerritbot added a comment.Jan 24 2025, 4:53 PM

Change #1093301 merged by jenkins-bot:

[design/codex@main] styles: Implement `:focus-visible` in Card and Accordion components

https://gerrit.wikimedia.org/r/1093301

bmartinezcalvo updated the task description. (Show Details)Jan 27 2025, 10:48 AM
Volker_E removed a project: Patch-For-Review.Feb 3 2025, 5:30 PM
gerritbot added a comment.Feb 4 2025, 4:48 PM

Change #1117223 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.20.0 to v1.20.1

https://gerrit.wikimedia.org/r/1117223

gerritbot added a project: Patch-For-Review.Feb 4 2025, 4:48 PM
PatchDemoBot added a comment.Feb 4 2025, 4:54 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/9c22725d87/w/

gerritbot added a comment.Feb 4 2025, 5:26 PM

Change #1117223 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.20.0 to v1.20.1

https://gerrit.wikimedia.org/r/1117223

PatchDemoBot added a comment.Feb 4 2025, 6:21 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/9c22725d87/w/

AnneT closed this task as Resolved.Feb 10 2025, 4:47 PM
Hridyesh_Gupta added a project: RoadToWiki.Mar 5 2025, 1:29 PM
Hridyesh_Gupta moved this task from Incoming to Completed on the RoadToWiki board.Mar 5 2025, 1:44 PM
Hridyesh_Gupta removed a project: Patch-For-Review.Mar 25 2025, 11:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits