Page MenuHomePhabricator

DNSBL related block settings broken.
Closed, ResolvedPublic

Description

The DNSBL related settings are broken.

If you're detected as being blacklisted, the following happens:

$this->mBlockedby = wfMsg( 'sorbs' );
$this->mBlockreason = wfMsg( 'sorbsreason' );

However, the actual methods to see if your blocked look for $this->mBlock being a real block object. Hence you're not actually blocked.

Not sure what the cleanest solution would be. either change relavent methods of user to not look for $this->mBlock, or introduce a new FakeBlock class for cases where the user doesn't have a block in db, but is blocked.


Version: 1.19
Severity: normal

Details

Reference
bz35303

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:13 AM
bzimport set Reference to bz35303.
bzimport added a subscriber: Unknown Object (MLST).

happy.melon.wiki wrote:

I'd definitely support FakeBlock, probably as an abstract class that can be implemented as SorbsFakeBlock, or TorFakeBlock, etc. The connection between the new Block stuff and the old User code is still pretty ugly in trunk...

r114117 claims this bug is fixed

  • Bug 34385 has been marked as a duplicate of this bug. ***