| Arian_Bozorg | |
| Aug 22 2024, 11:18 AM |
| F57286046: image.png | |
| Aug 22 2024, 11:18 AM |
| F57286038: image.png | |
| Aug 22 2024, 11:18 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
In the mobile view "No label defined" appears in red for languages that have no label defined, but have a mul label placeholder label
What should have happened instead?:
The placeholder label should appear in grey for languages that have no label defined and default to the mul label as it appears on desktop:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Goal | Arian_Bozorg | T285156 [GOAL] Add termbox language code mul to reduce redundancy in Wikidata Labels and Aliases | ||
| Open | None | T312097 [EPIC] MUL - Default values for labels and aliases | |||
| Resolved | BUG REPORT | Arian_Bozorg | T373088 [MUL] placeholder labels not appearing on mobile |
Had a quick look at this this morning. The "bug" here appears to be that mul has never been implemented for the mobile termbox. There is no support for mul labels, descriptions or aliases either in view or in edit mode. It feels like the scope for this is bigger than the ticket description - addressing only the placeholder issue won't result in a good user experience. Beyond that, saying "should appear in grey" as the desired behaviour is also a long way from a UX specification. Do we have designs for how the mul feature is supposed to work on mobile?
Moving this to task breakdown while we wait for feedback on how the feature should be implemented.
Per feedback from @Arian_Bozorg, the plan is to implement the specific fix for the reported issue now, and Arian will continue to research how the mul feature is supposed to be implemented for Termbox.
Change #1071177 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):
[wikibase/termbox@master] Add mul label support to mobile termbox
Change #1071177 merged by jenkins-bot:
[wikibase/termbox@master] Add mul label support to mobile termbox
Hm, I think I dropped the ball on this after clicking +2. I think we need both of the following:
I think they can be done in any order.
Change #1073245 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update termbox (mul support)
Change #1073247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[operations/deployment-charts@master] termbox: update to 2024-09-09-102106-production
Change #1073245 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox (mul support)
Change #1073247 merged by jenkins-bot:
[operations/deployment-charts@master] termbox: update to 2024-09-09-102106-production
This is now deployed for the server-side termbox and will roll out for the client-side termbox with next week’s train (unless we backport it this week).
Change #1073478 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.23] Update termbox (mul support)
Change #1073479 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.22] Update termbox (mul support)
(I’m backporting the fix now because I feel like it’s awkward if the SSR is out of sync for so long, even though I don’t think it causes any technical issues. And also getting MUL improvements into the community’s hands is nice anyway.)
Change #1073479 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.22] Update termbox (mul support)
Reason:
not really needed anymore now that group1 is on wmf.22
Change #1073478 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.43.0-wmf.23] Update termbox (mul support)
Mentioned in SAL (#wikimedia-operations) [2024-09-18T15:54:14Z] <hashar@deploy1003> Started scap sync-world: Update termbox (mul support) - T373088
Mentioned in SAL (#wikimedia-operations) [2024-09-18T16:01:03Z] <hashar@deploy1003> Finished scap sync-world: Update termbox (mul support) - T373088 (duration: 06m 48s)